Date: Wed, 10 Apr 2013 08:13:31 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Michael Gmelin <freebsd@grem.de> Cc: Chris Rees <utisoft@gmail.com>, freebsd-ports@freebsd.org Subject: Re: www/nginx pkg-plist + pkgng (detectable?) Message-ID: <20130410061331.GA74304@ithaqua.etoilebsd.net> In-Reply-To: <20130409205950.677a6812@bsd64.grem.de> References: <20130330034028.0f8cefc8@bsd64.grem.de> <5156C0D9.50909@FreeBSD.org> <20130330142320.38010126@bsd64.grem.de> <20130408103118.67ea695a@bsd64.grem.de> <CADLo838OFhmA6AQNuHPjP=Kfw9Co9vWh3XqxrFkEH-dgb81pzA@mail.gmail.com> <20130409205950.677a6812@bsd64.grem.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 09, 2013 at 08:59:50PM +0200, Michael Gmelin wrote: > On Tue, 9 Apr 2013 19:43:15 +0100 > Chris Rees <utisoft@gmail.com> wrote: >=20 >=20 > >=20 > > No, it's a bug in pkgng; it should respect @cwd. > >=20 No it is not. While i agree with pkgng that should repect @cwd (it surely does) There is nothing written anywhere that will waranty you that the @exec line= will be parsed in order ro prepend @cwd path to a path you provide. the only thi= ng doing that is %D. A user MUST add %D and have complete path in @exec lines In fact in that case it works by chance becauce of how pkg_install treat pl= ist. >=20 > pkg should respect @cwd for sure, but looking at nginx's plist I think > that it should use the cwd marker consistently, so right now it says: >=20 > %%WWWDATA%%@exec mkdir -p -m 755 www/nginx-dist > %%WWWDATA%%@exec if [ ! -d %D/www/nginx/ ] ; then ln -fs > %D/www/nginx-dist %D/www/nginx; fi > %%WWWDATA%%www/nginx-dist/EXAMPLE_DIRECTORY-DONT_ADD_OR_TOUCH_ANYTHING > %%WWWDATA%%www/nginx-dist/index.html %%WWWDATA%%www/nginx-dist/50x.html > %%WWWDATA%%@exec chmod a-w www/nginx-dist > %%WWWDATA%%@unexec if [ -L %D/www/nginx ]; then rm -f %D/www/nginx; fi > %%WWWDATA%%@dirrmtry www/nginx-dist >=20 > IMHO this should be: >=20 > %%WWWDATA%%@exec mkdir -p -m 755 %D/www/nginx-dist > %%WWWDATA%%@exec if [ ! -d %D/www/nginx/ ] ; then ln -fs > %D/www/nginx-dist %D/www/nginx; fi > %%WWWDATA%%www/nginx-dist/EXAMPLE_DIRECTORY-DONT_ADD_OR_TOUCH_ANYTHING > %%WWWDATA%%www/nginx-dist/index.html %%WWWDATA%%www/nginx-dist/50x.html > %%WWWDATA%%@exec chmod a-w www/nginx-dist > %%WWWDATA%%@unexec if [ -L %D/www/nginx ]; then rm -f %D/www/nginx; fi > %%WWWDATA%%@dirrmtry %D/www/nginx-dist >=20 Yes Michael you are totally right :) regards, Bapt --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFlAwsACgkQ8kTtMUmk6EykAQCeL8J0z9eX/ONBK3qKddNb8YXO iF4AnifKRH1yM0OspUjcNW889tyizlfu =eYki -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130410061331.GA74304>