Date: Tue, 9 Jul 2013 21:59:19 +0300 From: Mikolaj Golub <trociny@FreeBSD.org> To: Robert Millan <rmh@freebsd.org> Cc: freebsd-arch@freebsd.org Subject: Re: ABI change in libkvm (kvm_uread removal) Message-ID: <20130709185846.GA19508@gmail.com> In-Reply-To: <CAOfDtXPT-BQt9aqTNYHRK0XdiqKZsPnsO6s9vei=XCpyBvZZ6w@mail.gmail.com> References: <CAOfDtXPT-BQt9aqTNYHRK0XdiqKZsPnsO6s9vei=XCpyBvZZ6w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 09, 2013 at 07:45:59PM +0200, Robert Millan wrote: > Hi Mikolaj, > > In 2011 you removed kvm_uread() from libkvm, in r227839. > > Was this an intentional ABI change? I notice that kvm.h public header > still has the declaration. Also, the soname was not bumped. I think I thought then that kvm_uread() was for internal usage only (it was used by libkvm only for reading process args and env via procfs(5), no other consumers were found in base, no man page). Also reading from procfs(5) did not look like libkvm job, so after the last consumers had been removed, retiring it looked natural. I think I overlooked the declaration in kvm.h and that I might break ABI, otherwise it would have made me think more and ask other people if the removal was ok. > Should kvm.h and Makefile be adjusted to reflect the new ABI? Suggestions how this should be fixed properly (if possible) are highly appreciated. I will do what people suggest. -- Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130709185846.GA19508>