Date: Wed, 20 Nov 2013 09:55:31 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Doug Ambrisko <ambrisko@ambrisko.com> Cc: freebsd-hackers@freebsd.org, Dirk Engling <erdgeist@erdgeist.org>, Jase Thew <jase@freebsd.org>, mdf@freebsd.org Subject: Re: Re: Fix MNAMELEN or reimplement struct statfs Message-ID: <20131120075531.GE59496@kib.kiev.ua> In-Reply-To: <20131119174216.GA80753@ambrisko.com> References: <51B3B59B.8050903@erdgeist.org> <CAMBSHm8GMWffuuEcSpuNu26Mv4N2yAa2iEdw5koiXx0w30zPRQ@mail.gmail.com> <201306101152.17966.jhb@freebsd.org> <52854161.6080104@FreeBSD.org> <20131115010854.GA76106@ambrisko.com> <20131116183129.GD59496@kib.kiev.ua> <20131118190142.GA28210@ambrisko.com> <20131119074922.GY59496@kib.kiev.ua> <20131119174216.GA80753@ambrisko.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--mC3NEAINQo/WgN2+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 19, 2013 at 09:42:16AM -0800, Doug Ambrisko wrote: > I was talking about the more general case since the system tries to keep > the path in the stat structure. My prior approach which had more issues > was to modify the stat structure of which I was pointed to NetBSD and the= ir > change to statvfs which doesn't really solve the problem. They don't > have the check to see if the mount is longer then VFS_MNAMELEN (in their = case) > and just truncate things. >=20 > If we are just talking about adding it to the mount structure that > would be okay since it isn't exposed to user land. I can add that. Yes, this is exactly what I mean. Add a struct mount field, and use it for kernel only. In fact, it only matters for sys_unmount() and kern_jail.c, other locations in kernel use the path for warnings, and this could be postponed if you prefer to minimize the patch. --mC3NEAINQo/WgN2+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSjGrzAAoJEJDCuSvBvK1BNYIQAIk75V37Pla/9LCW62TXNEuI idymxdkG8Rnc0PKH3BfgtpJ+97qTZuI0GPFryyAuZjdT0DUFHni5LQ3lwsmlJJ5m lLjaMEkZbGumMocAI311l+5n9BYiSNivwHdeJFl3uBA9yZSbK98n2QJJDdqK6CMk LTaYCT0caoPacvJ8SbtfL0g9qqaGuE3t8ny+cBry+wSeS94PyDx+SzZ2vYLCyael yLCzELHUzklQGpTuSU4e+sudr9km1y5pu60VpKiI46EB6kZLAe679PzP9VIBwgA+ fHlR2Q7NkgiETH1acAe6a8Qja6V2x+ETUHsVMTljyFuVKtYQJrT0l7M8swJKjBtG PU16oCNPAfw6Rzz9+mFGqBAlFanoPVkb2l2C4fXzcPuyavlwJZQ2HE0b6i10uNFh y53zmJYLHz0VZtUTcSOBdRrBbS5eInEckZyLzUBL3c/GUcSeZbdy+kTc+3DEFiMh oSSQRsiwzebUB2woocbqFtxutySsUC9mNoA3o2JvPiWe+whj9PNPvlRK9+JJ4Wl/ i0oA1tBgC0AKuzp7M+jm6aIe8TnElxjirw/bfRU7+g1wsb3DPN5mEb85RHf2F3HB 49TIRCiJ/TzsSaeY1Vw6287QRU//xcZqus1NZV0d9grk9WxZ02gltnJ2SpqhTTUG EcKVtz963Ek1zy4+nq6l =WZx2 -----END PGP SIGNATURE----- --mC3NEAINQo/WgN2+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131120075531.GE59496>