Date: Mon, 21 Apr 2014 17:59:50 -0700 From: Greg Byshenk <freebsd@byshenk.net> To: Adrian Chadd <adrian@freebsd.org> Cc: "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: svn commit: r264710 - head/sys/dev/ath Message-ID: <20140422005950.GE1602@mail0.byshenk.net> In-Reply-To: <CAJ-Vmo=bbabyZbAq5s3nnChN7i=4YCkMnHKSdthPr6ZzQ4XNvA@mail.gmail.com> References: <201404210205.s3L25p9U064240@svn.freebsd.org> <CAJ-Vmo=Fzt7RtRfEidQ3vo_vFmc6W6M%2BWXR6pV1%2B8bR4Rus8uA@mail.gmail.com> <20140421155853.GD1602@mail0.byshenk.net> <CAJ-Vmo=bbabyZbAq5s3nnChN7i=4YCkMnHKSdthPr6ZzQ4XNvA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 21, 2014 at 09:30:47AM -0700, Adrian Chadd wrote:
> Which NIC?
It is a TP-Link TL-WN951N "Wireless N PCI Adapter".
dmesg:
ath0: <Atheros 5416> mem 0xfe6f0000-0xfe6fffff irq 16 at device 0.0 on pci4
ath0: AR5416 mac 13.10 RF2133 phy 8.1
pciconf:
ath0@pci0:4:0:0: class=0x028000 card=0x3071168c chip=0x0023168c rev=0x01 hdr=0x00
vendor = 'Atheros Communications Inc.'
device = 'AR5008 Wireless Network Adapter'
class = network
On 9-STABLE, I see an occasional "stuck beacon" error, but all
carries on more or less happily after. On 10-STABLE, the errors
as mentioned. (It is 10-STABLE, revision 264683).
-greg
> On 21 April 2014 08:58, Greg Byshenk <freebsd@byshenk.net> wrote:
> > On Sun, Apr 20, 2014 at 07:09:33PM -0700, Adrian Chadd wrote:
> >> I didn't say it in the commit message, but this should be MFCed to stable/10 .
> >
> >
> > Adrian-
> >
> > I'm curious as to what this addresses.
> >
> > I attempted to move a router/access point to FreeBSD 10 over the
> > weekend, and had to revert back to 9 as it was a terrible failure.
> >
> > It would invariably spew out masses of 'stuck beacon; resetting'
> > errors, and then at some point (not obviuously correlated with
> > those errors) lock up (hard, requiring a hard reset).
> >
> > If it is something that the patch might address, then I'll watch
> > for an MFC to stable/10
> >
> > Thanks,
> > -greg
> >
> >
> >> On 20 April 2014 19:05, Adrian Chadd <adrian@freebsd.org> wrote:
> >> > Author: adrian
> >> > Date: Mon Apr 21 02:05:51 2014
> >> > New Revision: 264710
> >> > URL: http://svnweb.freebsd.org/changeset/base/264710
> >> >
> >> > Log:
> >> > Make sure bf_next is NULL'ed out when we're completing up an aggregate
> >> > frame through the cleanup path.
> >> >
> >> > Whilst here, fix the indenting for something I messed up.
> >> >
> >> > Tested:
> >> >
> >> > * AR5416, STA mode
> >> >
> >> > Modified:
> >> > head/sys/dev/ath/if_ath_tx.c
> >> >
> >> > Modified: head/sys/dev/ath/if_ath_tx.c
> >> > ==============================================================================
> >> > --- head/sys/dev/ath/if_ath_tx.c Mon Apr 21 02:04:37 2014 (r264709)
> >> > +++ head/sys/dev/ath/if_ath_tx.c Mon Apr 21 02:05:51 2014 (r264710)
> >> > @@ -4600,10 +4600,11 @@ ath_tx_comp_cleanup_aggr(struct ath_soft
> >> >
> >> > ATH_TX_UNLOCK(sc);
> >> >
> >> > - /* Handle frame completion */
> >> > + /* Handle frame completion as individual frames */
> >> > bf = bf_first;
> >> > while (bf) {
> >> > bf_next = bf->bf_next;
> >> > + bf->bf_next = NULL;
> >> > ath_tx_default_comp(sc, bf, 1);
> >> > bf = bf_next;
> >> > }
> >> > @@ -5849,7 +5850,7 @@ ath_tx_node_reassoc(struct ath_softc *sc
> >> > ":",
> >> > i);
> >> > /*
> >> > - * In case there's a followup call to this, only call it
> >> > + * In case there's a followup call to this, only call it
> >> > * if we don't have a cleanup in progress.
> >> > */
> >> > if (! tid->cleanup_inprogress) {
> >> >
> >> _______________________________________________
> >> svn-src-all@freebsd.org mailing list
> >> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
> >
> > --
> > greg byshenk - gbyshenk@byshenk.net - Portland, OR USA
--
greg byshenk - gbyshenk@byshenk.net - Portland, OR USA
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140422005950.GE1602>