Date: Wed, 16 Jul 2014 17:07:58 +0000 From: Brooks Davis <brooks@freebsd.org> To: Sean Fagan <sef@ixsystems.com> Cc: hackers@freebsd.org Subject: Re: Expanding on NO_ROOT: Categorizing installed files Message-ID: <20140716170758.GE60425@spindle.one-eyed-alien.net> In-Reply-To: <FE374F8B-ABF7-4497-B1C7-68E63612DC43@ixsystems.com> References: <FE374F8B-ABF7-4497-B1C7-68E63612DC43@ixsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--CdrF4e02JqNVZeln Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 15, 2014 at 02:10:24PM -0700, Sean Fagan wrote: > Based on feedback primarily from Brooke Davis, an update. The diffs are = at http://earth.kithrup.com/~sef/auto-diffs.txt -- due to the size, I could= not send them to the mailing list. >=20 > This primarily eliminates the environment passing; the cost of that is a = lot more invasiveness. (About 100k larger diffs, thus being unable to atta= ch them.) The vast majorify of the diff is make debugging garbage that looks like it was committed by accident. I won't provided any detailed review of the current patch except to say that there are a lot of apparently redundent instances of setting META_CATEGORY in Makefiles and still quite a lot of instances of .EXPORTVAR: META_CATEGORY. > I have not changed it from having a new "category=3D" to using "tag=3D"; = I looked at that, and don't think it's the best way to go, but am still loo= king. Given that the current use of tags=3D is basically unconsumed, I still don't understand why. > I also want to go over it and ensure that NO_ROOT is a strict superset of= LOG_META_INFO -- that is, -DNO_ROOT should set -DLOG_META_INFO, and thus m= ost places where I check for either, I should only check for LOG_META_INFO. That seems like a good direction. -- Brooks --CdrF4e02JqNVZeln Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlPGsW4ACgkQXY6L6fI4GtTqXgCeMaBlQCEWKN14WytR/S4NiqhO kRsAniK9Qj9UQCzphBV/qdggIk7i3i/k =+NRR -----END PGP SIGNATURE----- --CdrF4e02JqNVZeln--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140716170758.GE60425>