Date: Fri, 1 Aug 2014 15:21:18 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: Svatopluk Kraus <onwahe@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: domain_add(xxx) after domainfinalize... Message-ID: <20140801222118.GH50495@funkthat.com> In-Reply-To: <CAFHCsPXPZ3M2xk=P4XJvDx-NGZ0_GS573Ay2%2BMmnb21w3N%2B3UQ@mail.gmail.com> References: <20140801193403.GE50495@funkthat.com> <CAFHCsPXPZ3M2xk=P4XJvDx-NGZ0_GS573Ay2%2BMmnb21w3N%2B3UQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Svatopluk Kraus wrote this message on Sat, Aug 02, 2014 at 00:05 +0200: > Just what I've got in January 2011: > http://lists.freebsd.org/pipermail/freebsd-hackers/2011-January/034037.html Sadly, after three (or six+) years, it is clear that these bugs will not be fixed, and this warning message is not useful, since no one has stepped up to fix them.. btw, you might want to create a bug w/ the information you tracked down to hopefully help the person that decides to finally fix them, though I doubt they will ever be fixed as people apparently don't see bad behavior... Unless someone fixes the bugs in the next few days, I will commit the following patch: Index: uipc_domain.c =================================================================== --- uipc_domain.c (revision 266964) +++ uipc_domain.c (working copy) @@ -227,15 +227,10 @@ printf("WARNING: attempt to domain_add(%s) before " "domaininit()\n", dp->dom_name); #endif -#ifdef notyet - KASSERT(domain_init_status < 2, - ("attempt to domain_add(%s) after domainfinalize()", - dp->dom_name)); -#else - if (domain_init_status >= 2) - printf("WARNING: attempt to domain_add(%s) after " - "domainfinalize()\n", dp->dom_name); -#endif + /* + * XXX - there are bugs WRT to adding domain after domain_finalize is + * called + */ mtx_unlock(&dom_mtx); } > On Fri, Aug 1, 2014 at 9:34 PM, John-Mark Gurney <jmg@funkthat.com> wrote: > > > So, I have a laptop that devd loads the bluetooth module every time.. > > > > This means I get the following error on every boot: > > WARNING: attempt to domain_add(bluetooth) after domainfinalize() > > WARNING: attempt to domain_add(netgraph) after domainfinalize() > > > > Is there any real benefit to this warning? I just looked at the code, > > and the domain gets added despite the warning... > > > > Also, it looks like the pervious warning, we should just make that an > > if/panic since it's clearly a programming bug, or kill the ifndef > > INVARIANTS... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140801222118.GH50495>