Date: Thu, 29 Jan 2015 10:18:52 -0700 From: Will Andrews <will@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r277876 - in projects/zfsd/head/tests/sys/cddl/zfs/tests: cli_root/zpool_upgrade zil Message-ID: <20150129171841.GA23484@sol.firepipe.net> In-Reply-To: <2519DB92-D2AD-48BD-96AE-101168E9C163@gmail.com> References: <201501291423.t0TENWOO048247@svn.freebsd.org> <2519DB92-D2AD-48BD-96AE-101168E9C163@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 29, 2015 at 08:58:57AM -0800, Garrett Cooper wrote: > Please use atf_skip instead of atf_fail so the issues don't count > as failures. If you have bug numbers for the issues that would be nice > too in the error messages. To me, skipping tests is only done when the environment is not setup correctly for the test. Panics are a special case in that they cause an irreversible abort of the test run itself, and they *are* failures. We've adopted a practice of marking such tests as 'expected failure' and then preemptively failing them. Does that work for you? Bugs will come later if I don't have fixes I can commit. --=20 wca --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlTKa3EACgkQF47idPgWcsVsPwCbB3kf7YmhE9bNmtqEJiX1HmuK 3roAoJeF8BRN/iI9REZX9XBQ8tJX8wdI =yc9Y -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150129171841.GA23484>