Date: Sun, 15 Nov 2015 22:57:06 +0100 From: Marius Strobl <marius@alchemy.franken.de> To: David Wolfskill <david@catwhisker.org>, current@freebsd.org Subject: Re: Wake on LAN broken (probably between r290542 - r290606)? Message-ID: <20151115215706.GH31931@alchemy.franken.de> In-Reply-To: <20151114175636.GX91465@albert.catwhisker.org> References: <20151111143337.GN1235@albert.catwhisker.org> <20151114175636.GX91465@albert.catwhisker.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Qxx1br4bt0+wmkIi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Nov 14, 2015 at 09:56:36AM -0800, David Wolfskill wrote: > On Wed, Nov 11, 2015 at 06:33:37AM -0800, David Wolfskill wrote: > > ... > > But a quick perusal of > > <https://docs.freebsd.org/mail/current/svn-src-head.html>; doesn't show > > anything especially like a "smoking gun" -- to me, anyway. > > > > Can anyone else confirm or refute my observations? Or suggest a > > hint? I'll try narrowing it down myself, but I need to do it during > > times I'm at home (so I can manually power the machine back up when > > it fails to respond to WoL), so it may be a few days before I can > > accomplish much that way. > > .... > > r290565 still works; r290566 fails -- in my case. r290566 changed some > re(4) behavior, and the NIC on my affected machine is an re(4): > > re0@pci0:3:0:0: class=0x020000 card=0x05b71028 chip=0x816810ec rev=0x0c > hdr=0x00 > vendor = 'Realtek Semiconductor Co., Ltd.' > device = 'RTL8111/8168/8411 PCI Express Gigabit Ethernet > Controller' > class = network > subclass = ethernet > > from "pciconf -lv" while running: > > D freebeast.catwhisker.org 11.0-CURRENT FreeBSD 11.0-CURRENT #1904 r290565M/290565:1100089: Sat Nov 14 09:44:33 PST 2015 root@freebeast.catwhisker.org:/common/S3/obj/usr/src/sys/GENERIC amd64 > > I've placed a copy of a verbose dmes.boot in > <http://www.catwhisker.org/~david/FreeBSD/freebeast/>. > > I'm happy to test suggested changes. > *sigh* Okay, could you please test whether the attached patch restores WOL capability for you? Marius --Qxx1br4bt0+wmkIi Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="re.diff" Index: if_re.c =================================================================== --- if_re.c (revision 290566) +++ if_re.c (working copy) @@ -3851,6 +3852,11 @@ re_setwol(struct rl_softc *sc) CSR_READ_1(sc, RL_GPIO) & ~0x01); } if ((ifp->if_capenable & IFCAP_WOL) != 0) { + if ((sc->rl_flags & RL_FLAG_8168G_PLUS) != 0) { + /* Disable RXDV gate. */ + CSR_WRITE_4(sc, RL_MISC, CSR_READ_4(sc, RL_MISC) & + ~0x00080000); + } re_set_rxmode(sc); if ((sc->rl_flags & RL_FLAG_WOL_MANLINK) != 0) re_set_linkspeed(sc); --Qxx1br4bt0+wmkIi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151115215706.GH31931>