Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 03 Sep 2001 07:26:53 +0200
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        "Andrey A. Chernov" <ache@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc/stdio fdopen.c fflush.c fopen.c fseek.c ftell.c fvwrite.c local.h refill.c stdio.c 
Message-ID:  <20159.999494813@critter>
In-Reply-To: Your message of "Sun, 02 Sep 2001 12:10:12 PDT." <200109021910.f82JACD82362@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <200109021910.f82JACD82362@freefall.freebsd.org>, "Andrey A. Chernov
" writes:
>ache        2001/09/02 12:10:12 PDT
>
>  Modified files:
>    lib/libc/stdio       fdopen.c fflush.c fopen.c fseek.c ftell.c 
>                         fvwrite.c local.h refill.c stdio.c 
>  Log:
>  Move all stdio internal flags processing and setting out of __sread(),
>  __swrite() and __sseek() to higher level. According to funopen(3) they all
>  are just wrappers to something like standard read(2), write(2) and
>  lseek(2), i.e. must not touch stdio internals because they are replaceable
>  with any other functions knows nothing about stdio internals. See example
>  of funopen(3) usage in sendmail sources f.e.
>  
>  NOTE: this is original stdio bug, not result of my range checkin added.

NOTE:  You forgot to add "Reviewed by: xxx"

Or do you seriously think that mucking about in STDIO doesn't need
a review ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20159.999494813>