Date: Mon, 27 Jun 2016 13:55:33 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Slawa Olhovchenkov <slw@zxy.spb.ru>, ports@FreeBSD.org, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: pkg SAT_SOLVER bugs Message-ID: <20160627115533.gqvdsmtzwnvrrfuo@ivaldir.etoilebsd.net> In-Reply-To: <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Jun 27, 2016 at 12:38:02PM +0200, Hans Petter Selasky wrote: > Hi, > > I found some bugs in PKG with regard to the SAT_SOLVER environment variable. > Please find patch attached :-) > > Issues fixed: > 1) No need to use hash table when generating SAT rules for external solver. > Variables are already in a linear array. Fix encoding and decoding of SAT > data. > 2) Endless variable loop caused pkg to crash. > 3) it->inverse was checked for non-zero, while it should actually be checked > for -1 only. SAT rules produces were all negative. > > How to verify: > > make -C /usr/ports/math/picosat all install clean > > env SAT_SOLVER=picosat pkg upgrade > > --HPS Thank you I will look into shortly Best regards, Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcRQyAAoJEGOJi9zxtz5aIZkQAMJQv1kj+AAHPKvaT8L+tO21 Xr3BruHii53Q5BSIbccAb3rx2atPbziXJ/JWS4HfVpVUJ2hz2i1Z6hpD+krVt8Jg IXZnXzgIbaFbM/unDrTob3lEkn5/M6wTaFN7cUIMTR98ECDVhqMonEOZcr9rRFMp yE+W0CAlF5LKoLmMYML2tuDQnfW9Lkr8qkM1Ik0ag5uecX7u7JszO39dAnEM9Zph H9jtIWfHhaEmRqiJJ/gbHfcSo5fskvLF0TfdBlwytVjCM9vhXJO525pofEmcS8Y/ eZYXC6Rb/jFA20c7Xf4YoIo8AZEok419vF6GsfcVPQvSEBSDFrEq0fTdFgjq3DGh haJYtnaNA6EUf6p0Sb5ZEaJZtXUG46P/zY99LUTLXeP1KOkY3CnWxPuycdE4s5ej JShFs8ONwCOrJMabSuzsdisCXL2KWazsZKzJVdEIBQy5sblYHBiUoiphwLeJmkoL 50B7xqv4SFFpdEvGYLGxjZBI0yGQJWWmyH+vL/thjfuIOW+ubNu8pNiNtuiL/O4S tfkpXDTBEiY3OfLfybkm7mUpfpg/eV3nFo56IkGB6RhaM+gGK0d+5Hmu1lzg+Ur8 e4qpJcNJ9a0DOg9C6akstkGhBNISaz1mwMJJTo8OWleZaVQqSC9BvJZc3vpGfchQ PmrCeFdzRbaF2Ief6Mhu =MeX6 -----END PGP SIGNATURE-----help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160627115533.gqvdsmtzwnvrrfuo>