Date: Sun, 15 Feb 1998 00:18:45 -0800 From: "Jordan K. Hubbard" <jkh@time.cdrom.com> To: Chris Csanady <ccsanady@friley585.res.iastate.edu> Cc: freebsd-current@FreeBSD.ORG Subject: Re: CCD missing spl() call.. Message-ID: <20245.887530725@time.cdrom.com> In-Reply-To: Your message of "Sat, 14 Feb 1998 22:31:08 CST." <199802150431.WAA00428@friley585.res.iastate.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> There is also a off by one error in the handling of the
> partitions. Credit goes to OpenBSD for these. There are
> numerous other changes that would be worth integrating
> as well..
[Not just to you, but also to Terry and those others who still
see some merit in submitting changes this way]
These would go best as PRs since stuff sent to the -current mailing
list often go into the bit-bucket. Stuff sent to the PR database
often goes into the bit-bucket as well, admittedly but at least:
A) It's easier to search the PR database than it is through
thousands of -current mails for the occasional forgotten
fix.
B) There's an active PR-meister to handle the untended
PRs whereas noone is signed up to perform such a function
for the mailing lists.
C) It's easier for me and others to close a PR and let the PR
system tell the submitter that it's been attended to than it is
for us to play cut-and-paste with email messages so that
the same function can be done manually. Both of your
submitted fixes have been applied, thanks!
Jordan
>
> Chris
>
> *** ccd.c.old Sat Feb 14 22:27:17 1998
> --- ccd.c Sat Feb 14 20:27:12 1998
> ***************
> *** 631,637 ****
> ccdgetdisklabel(dev);
>
> /* Check that the partition exists. */
> ! if (part != RAW_PART && ((part > lp->d_npartitions) ||
> (lp->d_partitions[part].p_fstype == FS_UNUSED))) {
> error = ENXIO;
> goto done;
> --- 631,637 ----
> ccdgetdisklabel(dev);
>
> /* Check that the partition exists. */
> ! if (part != RAW_PART && ((part >= lp->d_npartitions) ||
> (lp->d_partitions[part].p_fstype == FS_UNUSED))) {
> error = ENXIO;
> goto done;
> ***************
> *** 973,978 ****
> --- 973,979 ----
> register int unit = cbp->cb_unit;
> int count, s;
>
> + s = splbio();
> #ifdef DEBUG
> if (ccddebug & CCDB_FOLLOW)
> printf("ccdiodone(%x)\n", cbp);
>
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20245.887530725>