Date: Thu, 08 Mar 2001 22:26:32 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Ian Dowse <iedowse@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_icmp.c ip_input.c Message-ID: <24132.984086792@critter> In-Reply-To: Your message of "Thu, 08 Mar 2001 11:03:27 PST." <200103081903.f28J3Rp36712@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yah! Good work! Is this by any chance related to the DUMMYNET problem rgrimes reported ? Poul-Henning In message <200103081903.f28J3Rp36712@freefall.freebsd.org>, Ian Dowse writes: >iedowse 2001/03/08 11:03:26 PST > > Modified files: > sys/netinet ip_icmp.c ip_input.c > Log: > It was possible for ip_forward() to supply to icmp_error() > an IP header with ip_len in network byte order. For certain > values of ip_len, this could cause icmp_error() to write > beyond the end of an mbuf, causing mbuf free-list corruption. > This problem was observed during generation of ICMP redirects. > > We now make quite sure that the copy of the IP header kept > for icmp_error() is stored in a non-shared mbuf header so > that it will not be modified by ip_output(). > > Also: > > Reported by: Mike Tancsa <mike@sentex.net> Many thanks to Mike for stalking this bug out ! -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?24132.984086792>