Date: Fri, 19 Feb 2016 21:30:41 -0500 (EST) From: Rick Macklem <rmacklem@uoguelph.ca> To: lev@FreeBSD.org Cc: freebsd-fs@freebsd.org Subject: Re: Panic in NFS client on CURRENT Message-ID: <2475129.4356736.1455935441771.JavaMail.zimbra@uoguelph.ca> In-Reply-To: <56C752CD.4090203@FreeBSD.org> References: <56C752CD.4090203@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Lev wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > > I've hit panic in NFSv4 client on fresh CURRENT, which looks like bug > 206634. > Oops, along with commenting out the panic(), the VI_UNLOCK() needs to be deleted/commented out. The attached patch (not yet tested by me) should do it. (Btw, this only applies to head/current and not stable/10 or earlier.) rick > I have core saved and could provide additional information. > > - -- > // Lev Serebryakov > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQJ8BAEBCgBmBQJWx1LNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w > ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGOTZEMUNBMEI1RjQzMThCNjc0QjMzMEFF > QUIwM0M1OEJGREM0NzhGAAoJEOqwPFi/3EeP5RQP+gIqYjxZKpUk+sxAoE1Tds1K > BOkBPeFPj38FuaWUFN3LmM2HH3DZpjjScHa3WUeNov7KNduBTnBB0QJbYUOmXThg > 9ggOExQR+Cjci1YmBBa/8m8Naeik0wza0XmdbUlzx/qMyfpEMPmITZqq9X+/dcbb > 7xxpwUTveR3mZc9z7yS6qFDN+oqUMILFF08jq3B+715My0f2urBSBNqP4CJ5lc/a > sTNo2jTZG9PWug7blVIX03cX/hwVz9Wa3io+p5XNF+8ZGq2b+86sSPYf/6FjPWh3 > g/pMfX+cVYiOVsyWewASnRKse4S2my5gZ4OTbtrnMjOhFPhDbacM65XBdKSBIQDK > IXEsod+YvyMB+cBjvReyErLV0KoYkY/u5TzfaVuSAvKZ+MwuFSo57m6u2XSG/Z5f > XBvcTElIvFf78ZAmqJ5heyJSgONUKEUDo17w74Um6l3d0gP2QZDVrx5QF6hLb7Tx > ssepvE9DIEOijImBkn78QbxRaJzqXLYckxp1LPM0XtspbjoZImfLrCm8jE3RQJFs > cIcNCE9iWR0DD1fgSl7C/eifljfkSxF8hKf601ZYtweXZ89OWCh/HP3O8TfS0Fj/ > 9vOHdtC/AtCMQVHU1kdRyvjRCrpjVQV5WweCf1q641DSXuHkSIhWz2rfueX4I187 > BUokRbH5pntYoubADtmN > =y6WT > -----END PGP SIGNATURE----- > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > [-- Attachment #2 --] --- fs/nfsclient/nfs_clvnops.c.sav 2016-02-19 18:01:47.796969000 -0500 +++ fs/nfsclient/nfs_clvnops.c 2016-02-19 18:06:15.135933000 -0500 @@ -3368,11 +3368,8 @@ nfs_lock1(struct vop_lock1_args *ap) * there isn't any race problem. */ if ((ap->a_flags & LK_TYPE_MASK) == LK_EXCLOTHER) { - if ((ap->a_flags & LK_INTERLOCK) == 0) - panic("ncllock1"); if ((vp->v_iflag & VI_DOOMED)) error = ENOENT; - VI_UNLOCK(vp); return (error); } return (_lockmgr_args(vp->v_vnlock, ap->a_flags, VI_MTX(vp),
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2475129.4356736.1455935441771.JavaMail.zimbra>