Date: Fri, 03 Apr 1998 19:37:24 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru> Cc: "Alok K. Dhir" <adhir@worldbank.org>, current@FreeBSD.ORG, adkin003@tc.umn.edu Subject: Re: More info RE: X slowdown in -current Message-ID: <2732.891625044@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 03 Apr 1998 21:12:12 %2B0400." <19980403211212.09449@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <19980403211212.09449@nagual.pp.ru>, =?koi8-r?B?4c7E0sXKIP7F0s7P1w== ?= writes: >On Fri, Apr 03, 1998 at 07:08:12PM +0200, Poul-Henning Kamp wrote: >> In message <Pine.BSF.3.96.980403114954.338A-100000@shadow.worldbank.org>, " >Alok >> K. Dhir" writes: >> > >> >This patch worked great. Is there any reason why it shouldn't be >> >committed? >> >> Yes there is a reason: it is wrong, it lacks a splhigh(). >> >> Please report on the version currently in -current. > > >This report/patch already *IS* for very latest version currently in >-current, your fix really fix nothing, the bug remains. Are you sure you are looking at 1.35 ? If you compare version 1.33 and 1.35 you will see that there is no change in spl() placement and protection. I simply fail to see what the heck you think you need to fuck with splhigh for... Try to diff 1.33 and 1.35 and see what I mean... -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." "Drink MONO-tonic, it goes down but it will NEVER come back up!" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2732.891625044>