Date: Fri, 14 Mar 1997 18:18:38 +0100 From: Eivind Eklund <eivind@dimaga.com> To: Nate Williams <nate@freefall.freebsd.org> Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/include endian.h Message-ID: <3.0.32.19970314181837.0163ba10@dimaga.com>
next in thread | raw e-mail | index | archive | help
At 08:19 AM 3/14/97 -0800, Nate Williams wrote:
>nate 97/03/14 08:19:21
>
> Branch: sys/i386/include RELENG_2_1_0
> Modified: sys/i386/include endian.h
> Log:
> YAMFC:
>
> When compiling with '-Wall -pedantic', the byte swapping macros gave the
> following warning:
> warning: ANSI C forbids braced-groups within expressions
>
> Adding __extension__ before the statement-expression seems to work right.
While you're in there, why not reverse the sense of the LINT flag? As it
is, linting get the GCC extensions, and a page of errors.
Besides, NTOHL etc are missing either parentheses or do{...}while(0) -
preferably the last. Presently, they get precedence errors if used in
expressions.
Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3.0.32.19970314181837.0163ba10>