Date: Fri, 04 Jun 1999 14:28:18 +0100 From: Roger Hardiman <roger@cs.strath.ac.uk> To: Nick Hibma <nick.hibma@jrc.it> Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, current@FreeBSD.ORG Subject: Re: cdevsw_add Message-ID: <3757D472.167E@cs.strath.ac.uk> References: <Pine.GSO.3.95q.990604150606.15420d-100000@elect8>
next in thread | previous in thread | raw e-mail | index | archive | help
Nick Hibma wrote: > > cdevsw_add() > This should definitely go into attach IMNSHO. > > Probe: Check whether hardware is there (no side effects if possible). > Attach:Get the device up and running and integrated into the kernel. > > With the priority probes this is even more distinct as a priority not > equal to 0 means 'no side effects, just checking'. I've just fixed the bt848 driver (bktr) where the cdevsw_add() was accidentally added to the BSDI bktr_probe() and not the FreeBSD bktr_probe. Although Bruce and Nick said this really belongs, in the _attatch() function, I've kept it in the _probe() function for consistency with all the other drivers. Roger -- Roger Hardiman | Telepresence Research Group roger@cs.strath.ac.uk | DMEM, University of Strathclyde tel: 0141 548 2897 | Glasgow, Scotland, G1 1XJ, UK fax: 0141 552 0557 | http://telepresence.dmem.strath.ac.uk To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3757D472.167E>