Date: Thu, 23 Nov 2000 23:55:38 +0100 From: Marko Cuk <cuk@nu.cuk.nu> To: Bosko Milekic <bmilekic@technokratis.com>, freebsd-net@freebsd.org, tmoestl@gmx.net Subject: Re: PATCH REVIEW Re: bug in bridging/dummynet code - PR kern/19551 Message-ID: <3A1DA06A.9F46ADC9@nu.cuk.nu> References: <Pine.BSF.4.21.0011231742040.32714-100000@jehovah.technokratis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a cryptographically signed message in MIME format. --------------ms471E791FB2801D9F340B3F49 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit I'll try it tommorov in my company. I'll go to bed now :). Cuk Bosko Milekic wrote: > I built a kernel with bridging + dummynet + ipfw and tested the diff. It > seems to be fine on my end, although I haven't gotten further feedback > from Marko. > > I've committed the fix to -CURRENT. I will wait a couple of days and MFC. > I'll close two of the three PRs now (because they directly relate to this > problem) and will leave the third one (already assigned to me) to close > in the couple of days, after I MFC this and another dummynet+bridging > related fix that went into -CURRENT about a month ago. > > Once again, thanks Thomas. Thank you Luigi for the input! > > On Wed, 22 Nov 2000, Luigi Rizzo wrote: > > > > Thomas, I have looked at and reviewed your patch, and have added one > > > hunk to bridge.c, please take a look at the "almost ready for commit" > > > version here: > > > > > > http://people.FreeBSD.org/~bmilekic/dumbridge.diff > > > > sounds ok to me (modulo testing). > > > > > Basically, I don't like the fact that we have to copy the ethernet > > > header back into the mbuf for dummynet in bdg_forward(), especially since > > > we just removed it before calling bdg_forward(). But, this is no fault of > > > > this was also part of my criticism to the original changes. > > I posted a suggestion for keeping the ethernet header together with > > the mbuf when calling ether_input() (in case, define a new function > > ether_input2() if backward compatibility was a concern) to avoid > > the need for M_PREPEND, and also (probably) to save some code in > > the in the individual drivers where the ethernet splitting is > > replicated and could be centralized in ether_input2(). > > > > But this is some change that now would require a lot of work > > in touching the individual drivers. > > > > thanks Bosko and Thomas for your work > > > > cheers > > luigi > > ----------------------------------+----------------------------------------- > > Luigi RIZZO, luigi@iet.unipi.it . ACIRI/ICSI (on leave from Univ. di Pisa) > > http://www.iet.unipi.it/~luigi/ . 1947 Center St, Berkeley CA 94704 > > Phone: (510) 666 2927 > > ----------------------------------+----------------------------------------- > > Regards, > Bosko Milekic > bmilekic@technokratis.com > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-net" in the body of the message --------------ms471E791FB2801D9F340B3F49 Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIILRwYJKoZIhvcNAQcCoIILODCCCzQCAQExCzAJBgUrDgMCGgUAMAsGCSqGSIb3DQEHAaCC CUkwggJWMIIBv6ADAgECAgsBAAAAAADi6OMbGjANBgkqhkiG9w0BAQUFADBdMQswCQYDVQQG EwJCRTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTETMBEGA1UECxMKQ2xhc3MgMSBDQTEe MBwGA1UEAxMVR2xvYmFsU2lnbiBDbGFzcyAxIENBMB4XDTAwMTExODE3NTAwNloXDTAwMTIx OTE3NTAwNlowNjEWMBQGA1UEAxQNY3VrQG51LmN1ay5udTEcMBoGCSqGSIb3DQEJARYNY3Vr QG51LmN1ay5udTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAuIuBAERjucydC5Dh3ubP ROY/sx0YtaiO0r6/6xJHfDlp7iJ6xpdj2PCK/MflRL2iUzQNODn8ng7hsa7+h8eURs7cXZIq rzOJK6Gzn57ij0hWAfv7+JFXl6EpxiadzeK9yW8sHUCiIn/3SpRmGqXtBDDfs1wmX67fzRQH 6bfAcv0CAwEAAaNDMEEwEQYJYIZIAYb4QgEBBAQDAgWgMAsGA1UdDwQEAwIE8DAfBgNVHSME GDAWgBQO3PC7Ejzd+mCnjycKm6cufnNpmjANBgkqhkiG9w0BAQUFAAOBgQIQ/OPaTYl3kAPP tJ33aHsVW91+3JiFc72B5ObZFSewd/UXTxSpVfG14SnTYhkUKuiF7ZQMF+ZlQW/jsi/uoxHx 9t5gSzum946riO+C+meKCvukspxXCswYGm45G98/5iqEX+FLU0Y3o8wwq6yLyCVMZ5LUO2Wm 68ATDWEKUM2IrDCCAzswggIjoAMCAQICCwIAAAAAANZ4ujryMA0GCSqGSIb3DQEBBAUAMG0x CzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMRswGQYDVQQLExJQcmlt YXJ5IENsYXNzIDEgQ0ExJjAkBgNVBAMTHUdsb2JhbFNpZ24gUHJpbWFyeSBDbGFzcyAxIENB MB4XDTk4MDkxNjEyMDAwMFoXDTA0MDEyODEyMDAwMFowXTELMAkGA1UEBhMCQkUxGTAXBgNV BAoTEEdsb2JhbFNpZ24gbnYtc2ExEzARBgNVBAsTCkNsYXNzIDEgQ0ExHjAcBgNVBAMTFUds b2JhbFNpZ24gQ2xhc3MgMSBDQTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAmjJY7csS PqvryFdmTEK8cIBgADYB7t/9/V7xcuHMqjPYhGIlL+AuKyJiIq+OXl1pRW0NQ6J3a5uaMfHy EAKH4YqBnPmMYrK8ZImHVZZWfCkDtezp9llOzLi9FLEHFl6l1GfQTUmr/1nPx7Kh+2EbmYcw NY8q1a30osItFfv+23kCAwEAAaNwMG4wCwYDVR0PBAQDAgAGMB0GA1UdDgQWBBQO3PC7Ejzd +mCnjycKm6cufnNpmjAfBgNVHSMEGDAWgBT84Gb2WjWZ60Ae0rgeQ7yYjh+KwzARBglghkgB hvhCAQEEBAMCAAcwDAYDVR0TBAUwAwEB/zANBgkqhkiG9w0BAQQFAAOCAQEAJSGOw9tLJwJO 6BczAJXaTkYeqdcWCpt+H8YA6+z535Vy8ZbeZodRv+VR0vn0WEnwIBYj82jooZzjHuiAPJDv JscCeodgNZ8s5J9OKnJyaV+EY3FoBzFytnnj6+e2LjqQVJo7hGjsohyU3pjHjAwUrbmnBQ2/ TQiFY6827nLlNZOKv42LBI6qwOlrqhfZVhs1yGReZAT9sUI89/TDLcfn5WqALpQ6b9NYaWsD YReIp8l6/wCAooLeOj6eq4fgVk6BhbNpxYYW6Yk/uIQ3dKgwS6mbmDet1ksx6gx+z9RdvB6e RBy2CwAfZy6acD9872USMbSnpMtdWyeaAed5n10o4jCCA6wwggKUoAMCAQICCwIAAAAAANZ4 uDfPMA0GCSqGSIb3DQEBBAUAMFcxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWdu IG52LXNhMRAwDgYDVQQLEwdSb290IENBMRswGQYDVQQDExJHbG9iYWxTaWduIFJvb3QgQ0Ew HhcNOTgwOTE1MTIwMDAwWhcNMDkwMTI4MTIwMDAwWjBtMQswCQYDVQQGEwJCRTEZMBcGA1UE ChMQR2xvYmFsU2lnbiBudi1zYTEbMBkGA1UECxMSUHJpbWFyeSBDbGFzcyAxIENBMSYwJAYD VQQDEx1HbG9iYWxTaWduIFByaW1hcnkgQ2xhc3MgMSBDQTCCASIwDQYJKoZIhvcNAQEBBQAD ggEPADCCAQoCggEBAL0gNUfRKNYIoxI5I0cNvXAhUg5XMZWmNFdr7H5DecMGUkjNvLWhmb3Y HzK8z9ducm0udyKQgk5Lj5oMAUKa2XBZtp0f5mPRDK0dTviFgfmu75+mUmFEeRp1ReBhVkVt Qow9csumpBK3mvXWYNBgULOOpqbstPQSzX+ozu+z4YUw/nLE5ud3s55YQdZRg4gHxrZpTzbe 0QtIP73WnyF0ZG8nBj5L/Q6mm7+kSFeMkO6JGAsCgRi+Z/5TYIgnuqNzNEtaVrTecwXtmJZd 7ErnQPxLCWLr0OMxT4XReqtZZyv7iA/rqoO9Nf1hJ+xmDkJX92nCDO/8asJuSdqPQTiuSKkC AwEAAaNjMGEwDgYDVR0PAQH/BAQDAgAGMB0GA1UdDgQWBBT84Gb2WjWZ60Ae0rgeQ7yYjh+K wzAfBgNVHSMEGDAWgBRge2YaRQ2XyolQL30EzTSo//z9SzAPBgNVHRMBAf8EBTADAQH/MA0G CSqGSIb3DQEBBAUAA4IBAQCbowhEzvKQnXHzMrMFarXqzymY3lU+oBZ9BnpE1q/S+hNYjPgc x6sdtBvvaWiYXAg5j+D3+0jMIee4M9sFqjQkbErl6Xtg3oOzHwq+QXX8zDBIt8EmHQQzqrZ4 7SrLulaXMm73MZUuRvIU7ifH92KJuVxa0ziKZPU3tPGzNHLV1SE9S9d4k9cxZjUeo9hHSW8c reGAf/iYJGxzrA7CGncCoyYHt8drXbyC1SpIHWPPUDKm+xwYRxUKWwxcOCSaBJioCEhffDSH Y6stjUwAd5Qbdrr1FhijFa8vlPYpAHbBFRfT6TdNdtTLSylZJKzaSqDqY95fVLH689FFy8Vk tHMhMYIBxjCCAcICAQEwbDBdMQswCQYDVQQGEwJCRTEZMBcGA1UEChMQR2xvYmFsU2lnbiBu di1zYTETMBEGA1UECxMKQ2xhc3MgMSBDQTEeMBwGA1UEAxMVR2xvYmFsU2lnbiBDbGFzcyAx IENBAgsBAAAAAADi6OMbGjAJBgUrDgMCGgUAoIGxMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0B BwEwHAYJKoZIhvcNAQkFMQ8XDTAwMTEyMzIyNTUzOFowIwYJKoZIhvcNAQkEMRYEFK/XBU47 CysdjapEtUcISf9vnYMcMFIGCSqGSIb3DQEJDzFFMEMwCgYIKoZIhvcNAwcwDgYIKoZIhvcN AwICAgCAMAcGBSsOAwIHMA0GCCqGSIb3DQMCAgFAMA0GCCqGSIb3DQMCAgEoMA0GCSqGSIb3 DQEBAQUABIGAGS1MSMlHrl1wrs9QC+15dFiigiOMlNGPOgc+IrO4uAPNFiTOw2H+ZNCi53gb peJQ3q5z3Z1fUcSbnqt+m75kXNqjn0FvypCrKYr5iwawFNkhO8X9G2HmoUYQDIzgKd9RFu7P o0JWYh0Y1M2/IIYifGUTbG5zuT/2QXfFOOsuknM= --------------ms471E791FB2801D9F340B3F49-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A1DA06A.9F46ADC9>