Date: Thu, 20 Dec 2001 16:17:21 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Peter Wemm <peter@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c src/sys/i386/i386 pmap.csrc/sys/ia64/ia64 pmap.c Message-ID: <3C21F2F1.542EE5CC@FreeBSD.org> References: <20011221005726.Q884-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote:
>
> On Wed, 19 Dec 2001, Peter Wemm wrote:
>
> > peter 2001/12/19 21:29:59 PST
> >
> > Modified files:
> > sys/alpha/alpha pmap.c
> > sys/i386/i386 pmap.c
> > sys/ia64/ia64 pmap.c
> > Log:
> > Replace a bunch of:
> > for (pv = TAILQ_FIRST(&m->md.pv_list);
> > pv;
> > pv = TAILQ_NEXT(pv, pv_list)) {
> > with:
> > TAILQ_FOREACH(pv, &m->md.pv_list, pv_list) {
> >
> > Revision Changes Path
> > 1.79 +9 -28 src/sys/alpha/alpha/pmap.c
> > 1.301 +6 -20 src/sys/i386/i386/pmap.c
> > 1.41 +10 -30 src/sys/ia64/ia64/pmap.c
>
> This is a regression IMO. Please write C programs in something
> resembling C.
Why then we have all those *_FOREACH macros in sys/queue.h?
-Maxim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C21F2F1.542EE5CC>