Date: Tue, 29 Oct 2002 13:08:47 +0700 From: Eugene Grosbein <eugen@kuzbass.ru> To: Maxim Konovalov <maxim@FreeBSD.ORG> Cc: stable@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_fw.c (fwd) Message-ID: <3DBE25EF.AFDF596D@kuzbass.ru> References: <20021028154848.F68847-100000@news1.macomnet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Konovalov wrote: > > This is a direct commit to -STABLE. Please let me know ASAP if you > find any weirdness with ipfw after this commit. Thanks. > > -- > Maxim Konovalov, maxim@FreeBSD.org > > ---------- Forwarded message ---------- > Date: Mon, 28 Oct 2002 04:44:16 -0800 (PST) > From: Maxim Konovalov <maxim@FreeBSD.org> > To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org > Subject: cvs commit: src/sys/netinet ip_fw.c > > maxim 2002/10/28 04:44:16 PST > > Modified files: (Branch: RELENG_4) > sys/netinet ip_fw.c > Log: > o Fix remove_dyn_rule() logic. > o Re-lookup a parent after EXPIRE_DYN_CHAIN(). > o MFC rev. 1.14 ip_fw2.c: do not abuse console with 'session drop' messages. > > PR: kern/32600, kern/35887 > Submitted by: Dan Pelleg <daniel+bsd@pelleg.org> > Reviewed by: -stable > > Changes #1 and #2 do not apply to -CURRENT. > > Many thanks to Dan Pelleg <daniel+bsd@pelleg.org>, Dmitry Afanasiev > <dima@KOT.SPb.Ru>, Eugene Grosbein <eugen@kuzbass.ru> and Andrew Zavjalov > <jerom@gambit.com.ru> for testing. > > Revision Changes Path > 1.131.2.36 +17 -4 src/sys/netinet/ip_fw.c > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-stable" in the body of the message Please, please, change LOG_INFO to LOG_DEBUG, "drop session, too many entries\n" isn't informative at all, it does not even show rule number. And if it would, it flood syslog as it could not compress messages. There is really need of opportunity to separate this message from 'ipfw log'. Should I fill PR with obvious patch to make this happen? Eugene Grosbein To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3DBE25EF.AFDF596D>