Date: Thu, 25 Mar 2004 23:46:28 +0900
From: Alexander Nedotsukov <bland@FreeBSD.org>
To: Jeremy Messenger <mezz7@cox.net>
Cc: freebsd-gnome@FreeBSD.org
Subject: Re: Time to put ${PTHREAD_LIBS} in the x11/xscreensaver-gnome?
Message-ID: <4062F0C4.9000100@FreeBSD.org>
In-Reply-To: <opr5epdtjo8ckrg5@smtp.central.cox.net>
References: <opr5epdtjo8ckrg5@smtp.central.cox.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------000509030605000407060508
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Jeremy Messenger wrote:
> Hello,
>
> I do think that GNOME team should add the ${PTHREAD_LIBS} in the
> x11/xscreensaver-gnome at LDFLAGS line. There are few people have the
> same problem, so it's not just a Nvidia driver issue. Updated to 4.15
> must have changed something, because the older version doesn't
> required the ${PTHREAD_LIBS}.
Guys,
I don't think it's good idea because of two reasons:
1. I have xscreensaver-demo properly linked and running just fine here.
Plus since I have nvidia GL library installed when all GL hacks and
gl-helper mapped through libmap to use libc_r they also runs fine.
2. xscreensaver do not make any use of threading at all.
Even the way you proposing may fix situation on your side this is not
the right thing. I fact for nvidia users it will be better not to link
against any threading library at all. This is the way things also works
fine on my side.
Speaking about incorrect linking. To proove this is the case it's
necessary to found at least one object wich make use of pthreads API but
do not linked against it or two objects linked against different
threading libraries. As I said I don't see any.
Well to be constructive can people (not only once who currently
expirince a problem with xscreensaver) try the patch attached and report
two things is: it works and what is your GL library Nvidia/Mesa?
Thanks,
Alexander.
ps. Btw, others better follow my advise to figure out what is wrong with
your installation.
>
> Cheers,
> Mezz
>
>
--------------000509030605000407060508
Content-Type: text/plain;
name="xscreensaver-gnome.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="xscreensaver-gnome.patch"
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/x11/xscreensaver-gnome/Makefile,v
retrieving revision 1.23
diff -u -r1.23 Makefile
--- Makefile 2 Mar 2004 20:10:15 -0000 1.23
+++ Makefile 25 Mar 2004 14:07:04 -0000
@@ -7,6 +7,7 @@
PORTNAME= xscreensaver-gnome
PORTVERSION= 4.15
+PORTREVISION= 1
CATEGORIES= x11 gnome
MASTER_SITES= http://www.jwz.org/xscreensaver/
DISTNAME= xscreensaver-${PORTVERSION}
Index: files/patch-ab
===================================================================
RCS file: /home/ncvs/ports/x11/xscreensaver-gnome/files/patch-ab,v
retrieving revision 1.4
diff -u -r1.4 patch-ab
--- files/patch-ab 9 Nov 2003 04:03:40 -0000 1.4
+++ files/patch-ab 25 Mar 2004 13:57:32 -0000
@@ -1,6 +1,6 @@
---- configure.orig Sat Nov 8 22:45:13 2003
-+++ configure Sat Nov 8 22:45:58 2003
-@@ -2572,7 +2572,7 @@
+--- configure.orig Thu Mar 25 22:53:53 2004
++++ configure Thu Mar 25 22:57:09 2004
+@@ -2574,7 +2574,7 @@
if test -n "$GCC"; then
echo "$as_me:$LINENO: result: Turning on gcc compiler warnings." >&5
echo "${ECHO_T}Turning on gcc compiler warnings." >&6
@@ -9,7 +9,17 @@
OBJCC="$OBJCC -Wall"
# supposedly gcc 3.4 will have "-Wdeclaration-after-statement"
# and then perhaps we can do without -pedantic?
-@@ -18603,13 +18603,13 @@
+@@ -15346,9 +15346,6 @@
+ fi
+ echo "$as_me:$LINENO: result: $ac_cv_lib_pthread_pthread_create" >&5
+ echo "${ECHO_T}$ac_cv_lib_pthread_pthread_create" >&6
+-if test $ac_cv_lib_pthread_pthread_create = yes; then
+- GL_LIBS="-lpthread"
+-fi
+
+ fi
+
+@@ -19014,13 +19011,13 @@
# Now that we know whether we have Gnome, we can decide where the XML
# config files get installed.
#
--------------000509030605000407060508--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4062F0C4.9000100>