Date: Tue, 26 Apr 2005 19:19:41 -0700 From: Sam Leffler <sam@errno.com> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: Jose M Rodriguez <josemi@freebsd.jazztel.es> Subject: Re: rigth crc32 implementation Message-ID: <426EF6BD.6030207@errno.com> In-Reply-To: <20050426221922.GD8621@ns1.xcllnt.net> References: <200504261143.55195.josemi@redesjm.local> <20050426194208.GB7773@ns1.xcllnt.net> <426E9E1C.6020609@errno.com> <20050426221922.GD8621@ns1.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar wrote: > On Tue, Apr 26, 2005 at 01:01:32PM -0700, Sam Leffler wrote: > >>Note also there is CRC32 code of this sort in WEP and TKIP crypto >>modules in the net80211 support. > > > Sam, > > Given the seperation of crc32() into crc32_raw() and crc32(), with > either crc32() only or otherwise both functions inlined, are there > any obstacles preventing the 802.11 code from using the ones in > src/sys/libkern? The wep+tkip usage is integral to the cipher so splitting it out would likely slow them and, more importantly, would also require revalidation (there are test vectors but they're pretty limited). These modules are self-contained for various reasons so I'm leary of switching. I'll think about adding it under an #ifdef for those that want to save 2Kbytes (the size of the crc tables). Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?426EF6BD.6030207>