Date: Thu, 20 Aug 2009 05:49:38 -0700 (PDT) From: Barney Cordoba <barney_cordoba@yahoo.com> To: Manish Vachharajani <manishv@lineratesystems.com> Cc: freebsd-net@freebsd.org Subject: Re: Dropped vs. missed packets in the ixgbe driver Message-ID: <435336.24858.qm@web63908.mail.re1.yahoo.com> In-Reply-To: <5bc218350908191146j2a22f8dcrdecb0b67eedce5c2@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
=0A=0A--- On Wed, 8/19/09, Manish Vachharajani <manishv@lineratesystems.com= > wrote:=0A=0A> From: Manish Vachharajani <manishv@lineratesystems.com>=0A>= Subject: Re: Dropped vs. missed packets in the ixgbe driver=0A> To: "Barne= y Cordoba" <barney_cordoba@yahoo.com>=0A> Cc: freebsd-net@freebsd.org=0A> D= ate: Wednesday, August 19, 2009, 2:46 PM=0A> Agreed, the errors are reporte= d but=0A> missed packets are not.=A0 The=0A> question is, is the correct fi= x to just add stats.mpc[0] to=0A> if_ierrors=0A> in that line or to add it = to if_iqdrops.=A0 The fix is=0A> easy once we=0A> agree on what the correct= behavior is.=0A> =0A> Manish=0A> =0A> > Barney wrote:=0A> >=0A> > if you l= ook in ixgbe_update_stats_counters at the=0A> bottom:=0A> >=0A> > =A0 =A0 = =A0 =A0ifp->if_ierrors =3D missed_rx +=0A> adapter->stats.crcerrs +=0A> > = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0adapter->stats.rlec;=0A> >=0A> > the errors = are added in.=0A> >=0A> > BC=0A=0AHuh? missed_rx are the missed packets. So= they are counted.=0A=0ABC=0A=0A=0A
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?435336.24858.qm>