Date: Tue, 15 Aug 2006 14:53:56 +0200 From: Suleiman Souhlal <ssouhlal@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: current@freebsd.org Subject: Re: HEADS-UP: starting to commit linuxolator (SoC 2006) changes... Message-ID: <44E1C3E4.7080508@FreeBSD.org> In-Reply-To: <20060815144625.362bf376@Magellan.Leidinger.net> References: <20060815141151.15ae4349@Magellan.Leidinger.net> <44E1BD03.2030402@FreeBSD.org> <20060815144625.362bf376@Magellan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Leidinger wrote: > I already started... and I don't want to commit some parts (the linker > stuff which allows to use the module on amd64). > > It is also not used by default, as long as we have 2.4.2 for the linux > version, no new functions will be used by glibc. So there is no change > in behavior after the commits. I tested with acroread (which has issues > when run with a 2.6.16 compat.linux.osrelease version, where the new > functions are used by glibc). > > So this gives us: > - coverity reports for the code *before the end of the SoC* Why the rush? I'm sure Roman will be around even when the SoC is over. Also, I'm not asking you to wait a month, just a couple of days until more people have had a chance to look at the changes. It's a bit unreasonable to say "here's a patch, please look at it" and commit it less than a day later. > - no change in behavior in the default case, since the new calls > aren't used by glibs as long as... see following entry > - easy testing possibility (sysctl compat.linux.osrelease=2.6.16, > defaults to 2.4.2) > - more eyes on the code Those are not valid reasons to commit unreviewed and potentially wrong changes. -- Suleiman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44E1C3E4.7080508>