Date: Wed, 14 Nov 2007 11:01:32 +0100 From: Kris Kennaway <kris@FreeBSD.org> To: Julian Elischer <julian@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/bios apm.c Message-ID: <473AC77C.40903@FreeBSD.org> In-Reply-To: <200711140543.lAE5ht3O020823@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
Julian Elischer wrote: > julian 2007-11-14 05:43:55 UTC > > FreeBSD src repository > > Modified files: > sys/i386/bios apm.c > Log: > Apply the same sort of locking done in > sys/dev/acpica/acpi.c rev 1.196 a while ago: > > Grab Giant around calls to DEVICE_SUSPEND/RESUME in > acpi_SetSleepState(). > If we are resuming non-MPSAFE drivers, they need Giant held for them. > This may fix some obscure suspend/resume problems. It has fixed keyrate > setting problems that were triggered by cardbus (MPSAFE) changing the > ordering for syscons resume (non-MPSAFE). Also, add some asserts that > Giant is held in our suspend/resume and shutdown methods. > > Submitted by: Marko Zec > > Revision Changes Path > 1.149 +10 -0 src/sys/i386/bios/apm.c Why are we adding new unconditional giant acquisitions to the tree? Devices indicate whether or not they are mpsafe, why can't this be made conditional? Krishome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?473AC77C.40903>