Date: Sun, 24 Feb 2008 11:46:39 +0100 From: Kris Kennaway <kris@FreeBSD.org> To: Barney Cordoba <barney_cordoba@yahoo.com> Cc: current@freebsd.org Subject: Re: splimp() Message-ID: <47C14B0F.8050403@FreeBSD.org> In-Reply-To: <274346.34322.qm@web63914.mail.re1.yahoo.com> References: <274346.34322.qm@web63914.mail.re1.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Barney Cordoba wrote: > I'm porting some older software to 7.0 and I see that > many of the 7.0 drivers use both locks and splimps() > to protect code, particularly the firewire driver. > What cases would an splimp() be required? spl*() are NOPs that are only left behind in some code as a reminder of what mutual exclusion protections used to apply, mostly in cases where there has not been fine-grained locking applied to the code in question. In some (most?) cases they serve no useful annotation purpose and should just be removed. For newly written code they should be added. Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47C14B0F.8050403>