Date: Wed, 30 Aug 2000 18:42:33 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Sheldon Hearn <sheldonh@uunet.co.za> Cc: current@freebsd.org Subject: Re: recent change to conf.h breaks xosview port Message-ID: <4908.967653753@critter> In-Reply-To: Your message of "Wed, 30 Aug 2000 16:54:51 %2B0200." <67668.967647291@axl.fw.uunet.co.za>
next in thread | previous in thread | raw e-mail | index | archive | help
<sys/conf.h> should not be included from userland, and if it is a proper interface should be designed and used instead. Poul-Henning In message <67668.967647291@axl.fw.uunet.co.za>, Sheldon Hearn writes: > >Hi Poul-Henning, > >As of rev 1.116 of sys/sys/conf.h, the xosview port no longer builds. >Your delta added 3 struct timespec members to struct specinfo. > >The affected xosview file includes the following headers files in >order: > >#include <sys/param.h> >#include <sys/conf.h> > >[...] > >The breakage looks like this: > >In file included from swapinternal.cc:67: >/usr/include/sys/conf.h:59: field `si_atime' has incomplete type >/usr/include/sys/conf.h:60: field `si_ctime' has incomplete type >/usr/include/sys/conf.h:61: field `si_mtime' has incomplete type > >Including <sys/time.h> between the inclusion of <sys/param.h> and ><sys/conf.h> corrects the problem. > >Was this use of <sys/conf.h> always broken and only now problematic, or >is there a new problem in <sys/conf.h>? > >To me, it looks like <sys/conf.h> should pull <sys/time.h> in for >itself, although I understand that pollution comes along with that. > >Ciao, >Sheldo. > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD coreteam member | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4908.967653753>