Date: Mon, 19 Jan 2009 15:03:26 +0200 From: Manolis Kiagias <sonic2000gr@gmail.com> To: Gabor PALI <pgj@FreeBSD.org> Cc: doc@freebsd.org Subject: Re: Patches to the FDP Primer (from Last Year) Message-ID: <49747A1E.1080005@gmail.com> In-Reply-To: <685a6ef80901162151n36faf048tdad36c7a85c05731@mail.gmail.com> References: <685a6ef80901162151n36faf048tdad36c7a85c05731@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Gabor PALI wrote: > Folks, > > I created some patches for you to review during the translation of the > mighty FreeBSD Documentation Project Primer. Well, it has been a > while ago, but I think some things still should be fixed up. > > Here are the significant ones (others could be found in the same > directory, they usually fix typos, markup and capitalization as well > as the highlighted patches partially): > > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.doc-build.patch.diff > - Remove description of (documentation) package target as it is not > supported and it will be changed. Of course, the target in question > still lives in the Makefiles, but I would not mention it any more > (only when resurrected in some form). > So is the 'package' target broken? Admittedly I've never used it before reading your patch, but it seems it worked for me, building a package for the fdp-primer. I could install it with pkg_add, but then pkg_delete errored out trying to uninstall it. Not sure whether we should completely remove it from the docs though. The rest of the patch looks ok to me. > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.psgml-mode.patch.diff > - Mark up Emacs functions with <function> rather than <literal> > - Add port reference for editors/psgml > > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.see-also.patch.diff > - Fix broken links > > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.structure.patch.diff > - Rewrite the sentences about the Handbook images to provide more > up-to-date information instead of mentioning the possibility of > including images in a book > - Add some note on the localization of those images > > http://people.freebsd.org/~pgj/patches/2008/12/26/fdp-primer.the-website.patch.diff > - Add a description about WEB_LANG > > > All these look fine to me! > Note that I plan to bump the copyright year after the commits as there > are some content changes hiding in my proposed changes. > > Thank you in advance. > > Cheers, > :g > > > PS: I want to touch the "Translations" chapter too, but I still have > not got time to compose a usable patch for that. > _______________________________________________ > This is all nice work. I've been struggling with the translation of ppp-and-slip lately (plus I had rather limited spare time), hence the late reply. I think it would be ok to commit all the above, maybe get a few opinions on removing the reference to the package target. I see no other problems. Cheers, Manolis
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49747A1E.1080005>