Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Apr 2009 17:42:47 -0500
From:      Alan Cox <alc@cs.rice.edu>
To:        current@freebsd.org
Subject:   [Fwd: svn commit: r190949 - head/sys/vm]
Message-ID:  <49E11CE7.5050903@cs.rice.edu>

next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------050901080302090608030008
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

It's possible that this could cause problems for "exotic" languages that 
do their own memory management, i.e., they don't use libc's malloc().  
If anyone experiences or hears of such things, please let me know so 
that we can get the problems sorted out well before the 8.0 release.

Alan


--------------050901080302090608030008
Content-Type: message/rfc822;
 name="svn commit: r190949 - head/sys/vm.eml"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="svn commit: r190949 - head/sys/vm.eml"

Return-Path: <owner-src-committers@FreeBSD.org>
X-Original-To: alc@cs.rice.edu
Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1])
	by mail.cs.rice.edu (Postfix) with ESMTP id 0573C2C2B0E
	for <alc@cs.rice.edu>; Sat, 11 Apr 2009 17:34:27 -0500 (CDT)
X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu
X-Spam-Score: 0.009
X-Spam-Level: 
X-Spam-Status: No, score=0.009 tagged_above=-999 required=6.31
	tests=[AWL=0.009]
Received: from mail.cs.rice.edu ([127.0.0.1])
	by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new,
	port 10024) with LMTP id wdFMKib88sky for <alc@cs.rice.edu>;
	Sat, 11 Apr 2009 17:34:18 -0500 (CDT)
X-policyd-weight: using cached result; rate:hard: -8.5
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by mail.cs.rice.edu (Postfix) with ESMTP id 68CFA2C2B02
	for <alc@cs.rice.edu>; Sat, 11 Apr 2009 17:34:16 -0500 (CDT)
Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 055C3177073;
	Sat, 11 Apr 2009 22:34:15 +0000 (UTC)
	(envelope-from owner-src-committers@FreeBSD.org)
Received: by hub.freebsd.org (Postfix)
	id 971B9106567A; Sat, 11 Apr 2009 22:34:14 +0000 (UTC)
Delivered-To: alc@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 538)
	id 8A1FB1065677; Sat, 11 Apr 2009 22:34:14 +0000 (UTC)
Delivered-To: src-committers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3FD051065676;
	Sat, 11 Apr 2009 22:34:09 +0000 (UTC) (envelope-from alc@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 2E1248FC18;
	Sat, 11 Apr 2009 22:34:09 +0000 (UTC) (envelope-from alc@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3BMY9ZS001778;
	Sat, 11 Apr 2009 22:34:09 GMT (envelope-from alc@svn.freebsd.org)
Received: (from alc@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3BMY9LQ001777;
	Sat, 11 Apr 2009 22:34:09 GMT (envelope-from alc@svn.freebsd.org)
Message-Id: <200904112234.n3BMY9LQ001777@svn.freebsd.org>
From: Alan Cox <alc@FreeBSD.org>
Date: Sat, 11 Apr 2009 22:34:09 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
Subject: svn commit: r190949 - head/sys/vm
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: owner-src-committers@FreeBSD.org
Precedence: bulk
X-Loop: FreeBSD.ORG
X-DSPAM-Result: Whitelisted
X-DSPAM-Processed: Sat Apr 11 17:34:27 2009
X-DSPAM-Confidence: 0.7829
X-DSPAM-Probability: 0.0000
X-DSPAM-Signature: 49e11af3178421605918796

Author: alc
Date: Sat Apr 11 22:34:08 2009
New Revision: 190949
URL: http://svn.freebsd.org/changeset/base/190949

Log:
  Remove execute permission from the memory allocated by sbrk().
  
  Pre-announced on: -arch (3/31/09)
  Discussed with: rwatson
  Tested by: marius (sparc64)

Modified:
  head/sys/vm/vm_unix.c

Modified: head/sys/vm/vm_unix.c
==============================================================================
--- head/sys/vm/vm_unix.c	Sat Apr 11 22:07:19 2009	(r190948)
+++ head/sys/vm/vm_unix.c	Sat Apr 11 22:34:08 2009	(r190949)
@@ -117,7 +117,7 @@ obreak(td, uap)
 			goto done;
 		}
 		rv = vm_map_insert(&vm->vm_map, NULL, 0, old, new,
-		    VM_PROT_ALL, VM_PROT_ALL, 0);
+		    VM_PROT_RW, VM_PROT_ALL, 0);
 		if (rv != KERN_SUCCESS) {
 			error = ENOMEM;
 			goto done;

--------------050901080302090608030008--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49E11CE7.5050903>