Date: Mon, 01 Jun 2009 18:33:12 +0300 From: Andriy Gapon <avg@freebsd.org> To: freebsd-current@freebsd.org Subject: Re: fsck_y_enable: use -C Message-ID: <4A23F4B8.7000002@freebsd.org> In-Reply-To: <4A23D5A4.6020009@icyb.net.ua> References: <4A23D5A4.6020009@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
on 01/06/2009 16:20 Andriy Gapon said the following: > What about the following patch? > I believe that the idea behind fsck_y_enable is to try to make unattended systems > with rw filesystems as recoverable as possible at the cost of potential damage to > the data. The new "-C" option should not interfere with this goal, but should > reduce recovery time, because currently fsck -y checks *all* filesystems from > fstab, even those that are ro or clean: > > -C Check if the “clean” flag is set in the superblock and skip file > system checks if file system was properly dismounted and marked > clean. > One potential issue that I've just thought of is that fsck_msdosfs doesn't seem to support this option (even in a dummy way), so it would be a problem for those who have msdos filesystems in fstab and also have fsck_y_enable. > diff --git a/etc/rc.d/fsck b/etc/rc.d/fsck > index bf51089..c0cb359 100755 > --- a/etc/rc.d/fsck > +++ b/etc/rc.d/fsck > @@ -45,7 +45,7 @@ fsck_start() > 8) > if checkyesno fsck_y_enable; then > echo "File system preen failed, trying fsck -y." > - fsck -y > + fsck -y -C > case $? in > 0) > ;; > -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A23F4B8.7000002>