Date: Wed, 03 Feb 2010 14:24:40 -0600 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Rafal Jaworowski <raj@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 174261 for review Message-ID: <4B69DB88.2050502@freebsd.org> In-Reply-To: <201002032021.o13KLkPO006520@repoman.freebsd.org> References: <201002032021.o13KLkPO006520@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Rafal Jaworowski wrote: > http://p4web.freebsd.org/chv.cgi?CH=174261 > > Change 174261 by raj@raj_fdt on 2010/02/03 20:20:54 > > Bring more endian-safety for FDT uart(4) attachment. > > Affected files ... > > .. //depot/projects/fdt/sys/dev/uart/uart_bus_fdt.c#5 edit > > Differences ... > > ==== //depot/projects/fdt/sys/dev/uart/uart_bus_fdt.c#5 (text+ko) ==== > > @@ -1,5 +1,5 @@ > /*- > - * Copyright (c) 2009 The FreeBSD Foundation > + * Copyright (c) 2009-2010 The FreeBSD Foundation > * All rights reserved. > * > * This software was developed by Semihalf under sponsorship from > @@ -35,11 +35,15 @@ > #include <sys/kernel.h> > #include <sys/module.h> > > +#include <machine/bus.h> > + > #include <dev/ofw/ofw_bus.h> > #include <dev/ofw/ofw_bus_subr.h> > #include <dev/uart/uart.h> > #include <dev/uart/uart_bus.h> > > +#include "../../contrib/dtc/libfdt/libfdt_env.h" > + > static int uart_fdt_probe(device_t); > > static device_method_t uart_fdt_methods[] = { > @@ -81,8 +85,11 @@ > sizeof(clock))) <= 0) > clock = 0; > > + clock = fdt32_to_cpu(clock); > + Can't you just use ntoh*? As far as I know, FDT (and Open Firmware) are defined to always use network byte order. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B69DB88.2050502>