Date: Wed, 13 Oct 2010 09:41:47 -0700 From: Matthew Jacob <mj@feral.com> To: freebsd-geom@freebsd.org Subject: Re: HEADS UP: device name checking on device registration Message-ID: <4CB5E14B.9070308@feral.com> In-Reply-To: <20101013085025.GB54686@jh> References: <20101007180657.GA1383@a91-153-123-205.elisa-laajakaista.fi> <20101013085025.GB54686@jh>
next in thread | previous in thread | raw e-mail | index | archive | help
I think this seems good. Perhaps you could also fix devfs to not panic when somebody tries to make a device that already exists and just return an error with a diagnostic while you're at it? On 10/13/2010 1:50 AM, Jaakko Heinonen wrote: > [Posting a patch to -geom for comments.] > > On 2010-10-07, Jaakko Heinonen wrote: >> Currently several GEOM classes (notably geom_label) allow to create >> devices with invalid names. Below is a link to a patch which converts >> g_dev_taste() to use make_dev_p() with MAKEDEV_CHECKNAME flag. It's not >> a complete solution and essentially changes the panic to a printf. > What do you think about this patch? > > http://people.freebsd.org/~jh/patches/geom_dev-checkname.2.diff > > Any better ideas how to handle this in GEOM? It doesn't seem to be > trivial to propagate an error from g_dev_taste() due to asynchronous > nature of the device registration in GEOM. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CB5E14B.9070308>