Date: Tue, 19 Oct 2010 06:56:01 -0700 From: Matthew Jacob <mj@feral.com> To: Alexander Best <arundel@FreeBSD.ORG> Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: SCSI_DELAY cleanup Message-ID: <4CBDA371.4080801@feral.com> In-Reply-To: <20101019103432.GA69208@freebsd.org> References: <20101018235318.GA87158@freebsd.org> <4CBCE67C.1070106@feral.com> <20101019103432.GA69208@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
It would be an effective behavioral change for those of us who remove that line. Personally, I think 5 seconds is too long- even 2 seconds is more than adequate even for moderately old 'other' hardware like scanners. For -current, why don't you simply remove all of the config lines and leave the default at 2000ms? On 10/19/2010 3:34 AM, Alexander Best wrote: > On Mon Oct 18 10, Matthew Jacob wrote: >> What problem are you solving by this change? > code cleanup. > > the scsi delay value currently defaults to 2000ms. however that doesn't make > sense, since on almost all platforms it gets set to 5000ms in the default > config. what's the purpose of having a default value, if it is much more often > overwritten than actually used? > > that's why this patch changes the default scsi delay value to 5000ms. now all > of the lines that were setting the scsi delay value to 5000ms can be removed. > also default values should be chosen very conservatively. users can always > lower the delay value via their kernel config or sysctl. > > cheers. > alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CBDA371.4080801>