Date: Thu, 23 Dec 2010 11:13:01 +0200 From: Alexander Motin <mav@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216649 - projects/graid/head/sys/geom/raid Message-ID: <4D13129D.3080606@FreeBSD.org> In-Reply-To: <20101223090812.GA43446@garage.freebsd.pl> References: <201012220902.oBM92MpZ098772@svn.freebsd.org> <20101223090812.GA43446@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Jakub Dawidek wrote: > On Wed, Dec 22, 2010 at 09:02:22AM +0000, Alexander Motin wrote: >> Author: mav >> Date: Wed Dec 22 09:02:22 2010 >> New Revision: 216649 >> URL: http://svn.freebsd.org/changeset/base/216649 >> >> Log: >> Implement basic metadata generation check. To be sure that used metadata is >> up to date - delay volumes creation until we have all disks or timeout >> expires. This probably obsolete same functionality done at volumes level. > [...] >> +static struct intel_raid_conf * >> +intel_meta_copy(struct intel_raid_conf *meta) >> +{ >> + struct intel_raid_conf *nmeta; >> + >> + nmeta = malloc(meta->config_size, M_MD_INTEL, M_WAITOK | M_ZERO); >> + memcpy(nmeta, meta, meta->config_size); >> + return (nmeta); >> +} > > The M_ZERO flag seems to be redundant, as you fill the entire buffer in > the next line. Indeed. Thanks. But I am sure it is not the biggest of my problems. :) -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D13129D.3080606>