Date: Tue, 28 Dec 2010 14:06:10 -0700 From: Warner Losh <imp@bsdimp.com> To: Juli Mallett <jmallett@FreeBSD.org> Cc: freebsd-mips@FreeBSD.org Subject: Re: [PATCH] Retrieval of TLS pointer via RDHWR Message-ID: <4D1A5142.5090205@bsdimp.com> In-Reply-To: <AANLkTi=zjYMG-9P-EoxJjCz=ibUiXESbqLAq_D=e-X%2BN@mail.gmail.com> References: <AANLkTimg3CUk0p8YPyepiumEHvKo2F6jdVA0=1CefYrQ@mail.gmail.com> <AANLkTikxHUj%2BGe3YyJOWMQne31D=uY_712Qveq=Dmh2A@mail.gmail.com> <AANLkTimyqAWFo5Ddd8_UAL654iGquCMnEjFETUnsFdxO@mail.gmail.com> <AANLkTi=nyXw3Tw-BnhAMwob4yP0-TSxeh5f_wEjtEfQ9@mail.gmail.com> <4D1A1B83.5070602@bsdimp.com> <AANLkTim1eqsA9xzPM9H48-3%2B1DKdDpUxrEE=YQ%2Bv-Vdh@mail.gmail.com> <AANLkTi=zjYMG-9P-EoxJjCz=ibUiXESbqLAq_D=e-X%2BN@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/28/2010 13:37, Juli Mallett wrote: > On Tue, Dec 28, 2010 at 12:35, Robert Millan<rmh@debian.org> wrote: >> Thank you. So can it be committed, or does it need improvement >> of some kind first? > It seems to me that rather than waffling we should just commit it. > Assuming someone tests it and is confident in the implementation, I > can't see why they'd have a problem committing it. I reviewed the patch, and I liked it. Couldn't find anything wrong with it when I first looked at it. Would be nice if things were more flexible, but since generalizing from a sample size of one can be hard, I totally agree. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D1A5142.5090205>