Date: Sat, 22 Jan 2011 16:13:18 +0100 From: Jan Henrik Sylvester <me@janh.de> To: Chris Rees <utisoft@gmail.com> Cc: ports-list freebsd <freebsd-ports@freebsd.org> Subject: Re: Xournal: Please, help me with my first port Message-ID: <4D3AF40E.7090301@janh.de> In-Reply-To: <AANLkTinU4rCAhgW2=3eNTPgPdftPDn8KiBF_ORGmVqtX@mail.gmail.com> References: <4D39FEBA.3000806@janh.de> <AANLkTimSe3wBQ_FPdfDtgcLH-bDXsDfX2AZ3hsD5Xff4@mail.gmail.com> <AANLkTinU4rCAhgW2=3eNTPgPdftPDn8KiBF_ORGmVqtX@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/22/2011 14:04, Chris Rees wrote: > On 22 January 2011 12:53, Chris Rees<utisoft@gmail.com> wrote: >> On 21 January 2011 21:46, Jan Henrik Sylvester<me@janh.de> wrote: >>> Finally, I found an application worse having that is not in ports and looked >>> simple enough to try: Xournal is my first attempt to create a new port. >>> >>> I followed the handbook and did the basic testing with porttools: There are >>> warnings about considering to use DATADIR if the port was DATADIR-safe, but >>> I do not assume it to be. >>> >>> Moreover, there is a warning about my post-patch line. I think the warning >>> is wrong, but I am unsure about that line anyhow. The desktop-install target >>> in Makefile.in is wrong for FreeBSD, but there is probably a better way to >>> fix it. >>> >>> Is my attempt to use the desktop-install target via post-install correct? >>> >>> Do all the files installed by the post-install target go to the correct >>> locations? >>> >>> Is there anything else I should fix before submitting the port as pr? >>> >>> In case the attachment does not make it to the list, I have placed a copy >>> here: http://www.math.uni-hamburg.de/home/sylvester/xournal.shar >>> >> >> The DATADIR whines are addressed in this patch, have a look: >> >> http://www.bayofrum.net/~chris/patches/xournal-pkg-plist.diff Thanks, but since the port does not honor DATADIR, it should not be there -- or the DATADIR case must be fixed first. >> That's all I had time to look at at the moment, perhaps others can help! >> > > Alright, came back and now the patch has the desktop-install target > defined instead of using the post-install. This is reflected in the > patch linked above ^^^ Thanks, I was looking for something like that, but it should be "INSTALL_TARGET= install desktop-install", because desktop-install does not include install. > I've stuck it in my Tinderbox for testing, follow it here: > http://tinderbox.bayofrum.net/index.php?action=describe_port&id=196 Thanks! I do not know Tinderbox enough to understand, why your mkfontscale build tried to install an outdated version of freetype2. Cheers, Jan Henrik
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D3AF40E.7090301>