Date: Fri, 14 Oct 2011 15:31:36 -0500 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: "Jayachandran C." <jchandra@freebsd.org> Cc: Rafal Jaworowski <raj@semihalf.com>, Marcel Moolenaar <marcel@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [RFC] FDT fix for 64 bit platforms Message-ID: <4E989C28.3030606@freebsd.org> In-Reply-To: <CA%2B7sy7AhU7WLuabx6HCtUgvEtUHWBmGe-eP=N8L9VknM65r-mg@mail.gmail.com> References: <CA%2B7sy7AhU7WLuabx6HCtUgvEtUHWBmGe-eP=N8L9VknM65r-mg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/14/11 14:10, Jayachandran C. wrote: > I'm planning commit this -CURRENT if there an no objections. > > In the current implementation, phandle is used to store a pointer to > the location inside the device tree. Since phandle_t is u32, this > will not work on 64 bit platforms. With this fix, the phandle is the > offset from the start of device tree pointer 'fdtp', which will be 32 > bit. > > Review or testing from device tree users will be welcome. > > JC. Why not use offsets into the FDT rather than full pointers? I believe having phandles greater than 32 bits violates the FDT spec, and declaring that the FDT can't itself be larger than 4 GB seems reasonable. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E989C28.3030606>