Date: Sun, 13 May 2012 20:08:14 +0400 From: Boris Samorodov <bsam@passap.ru> To: gnome@freebsd.org Subject: [patch] [CLANG] devel/gamin: does not compile with clang Message-ID: <4FAFDC6E.80409@passap.ru>
next in thread | raw e-mail | index | archive | help
Hi!
The port devel/gamin does not compile with clang:
-----
clang -DHAVE_CONFIG_H -I. -I.. -I.. -I../libgamin -I../protocol
-I../lib -I../libgamin -I/usr/local/include/glib-2.0
-DBINDIR=\""/usr/local/libexec"\" -DG_DISABLE_DEPRECATED
-DGAM_DEBUG_ENABLED -DHAVE_LINUX -I/usr/local/include -Wall
-Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes
-Wnested-externs -Wsign-compare -Wno-sign-compare -g -O2 -pipe
-fno-strict-aliasing -MT gam_eq.o -MD -MP -MF .deps/gam_eq.Tpo -c -o
gam_eq.o gam_eq.c
gam_eq.c:127:3: error: non-void function 'gam_eq_flush' should return a
value [-Wreturn-type]
return;
^
1 error generated.
gmake[3]: *** [gam_eq.o] Ошибка 1
-----
I'm not sure if it is TRTD but since the return value is not
checked, I propose the following patch (compiles and seems to
work):
-----
% cat /usr/ports/devel/gamin/files/patch-server_gam_eq.c
--- server/gam_eq.c.orig 2012-05-13 19:42:20.257794534 +0400
+++ server/gam_eq.c 2012-05-13 19:44:41.228799909 +0400
@@ -124,7 +124,7 @@ gam_eq_flush (gam_eq_t *eq, GamConnDataP
{
gboolean done_work = FALSE;
if (!eq)
- return;
+ return FALSE;
#ifdef GAM_EQ_VERBOSE
GAM_DEBUG(DEBUG_INFO, "gam_eq: Flushing event queue for %s\n",
gam_connection_get_pidname (conn));
-----
--
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FAFDC6E.80409>