Date: Fri, 03 Aug 2012 14:04:05 -0300 From: Marcelo Gondim <gondim@bsdinfo.com.br> To: Jim Harris <jimharris@freebsd.org> Cc: freebsd-stable@freebsd.org Subject: Re: geom_virstor with kernel panic in FreeBSD 9.x Message-ID: <501C0485.8070002@bsdinfo.com.br> In-Reply-To: <CAJP=Hc-r0zE6tDPQozEbmoSqD%2BHnxzqRzG=mummE7jWzQOsZEQ@mail.gmail.com> References: <1977769407.20120322151934@tkachuk.name> <4F6B4030.5090907@FreeBSD.org> <4F6B4631.8020006@gmail.com> <4F6B4B93.7020309@FreeBSD.org> <4F6B4FAB.1020202@gmail.com> <1332434072.8403.79.camel@revolution.hippie.lan> <E1SGoVX-000EYm-90@kabab.cs.huji.ac.il> <501B8004.1000503@ateamsystems.com> <501BBEBB.5010106@bsdinfo.com.br> <CAJP=Hc-r0zE6tDPQozEbmoSqD%2BHnxzqRzG=mummE7jWzQOsZEQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Em 03/08/2012 13:49, Jim Harris escreveu:
> ===================================================================
> --- sys/geom/virstor/g_virstor.c (revision 238909)
> +++ sys/geom/virstor/g_virstor.c (working copy)
> @@ -235,6 +235,12 @@
> return;
> }
> sc = virstor_find_geom(cp, name);
> + if (sc == NULL) {
> + gctl_error(req, "Don't know anything about '%s'", name);
> + g_topology_unlock();
> + return;
> + }
> +
> LOG_MSG(LVL_INFO, "Stopping %s by the userland command",
> sc->geom->name);
> update_metadata(sc);
Hi Jim,
When I applied the patch gave this error:
# patch < /root/patch.diff
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- sys/geom/virstor/g_virstor.c (revision 238909)
|+++ sys/geom/virstor/g_virstor.c (working copy)
--------------------------
Patching file sys/geom/virstor/g_virstor.c using Plan A...
Hunk #1 failed at 235.
1 out of 1 hunks failed--saving rejects to sys/geom/virstor/g_virstor.c.rej
done
# cat sys/geom/virstor/g_virstor.c.rej
***************
*** 235,240 ****
return;
}
sc = virstor_find_geom(cp, name);
LOG_MSG(LVL_INFO, "Stopping %s by the userland command",
sc->geom->name);
update_metadata(sc);
--- 235,246 ----
return;
}
sc = virstor_find_geom(cp, name);
+ if (sc == NULL) {
+ gctl_error(req, "Don't know anything about
'%s'", name);
+ g_topology_unlock();
+ return;
+ }
+
LOG_MSG(LVL_INFO, "Stopping %s by the userland command",
sc->geom->name);
update_metadata(sc);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?501C0485.8070002>