Date: Tue, 04 Sep 2012 21:48:27 +0400 From: Andrey Zonov <zont@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: Edward Tomasz Napierala <trasz@FreeBSD.org>, freebsd-arch@FreeBSD.org Subject: Re: [patch] unprivileged mlock(2) Message-ID: <50463EEB.60207@FreeBSD.org> In-Reply-To: <50463610.6070805@FreeBSD.org> References: <503DD433.2030108@FreeBSD.org> <201208290906.q7T96C9j032802@gw.catspoiler.org> <20120829092318.GW33100@deviant.kiev.zoral.com.ua> <503F2D24.8050103@FreeBSD.org> <503F476E.1010505@FreeBSD.org> <50463610.6070805@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 9/4/12 9:10 PM, Andriy Gapon wrote: > on 30/08/2012 13:58 Andrey Zonov said the following: >> [1] http://people.freebsd.org/~zont/vm_mmap.c.patch > > This patch is correct. > Thanks! >> [2] http://people.freebsd.org/~zont/racct.patch > > This patch looks correct. > There is no need for this patch as I mentioned earlier. racct_set() doesn't add any additional locking here. > And it also makes me wonder why kern/kern_racct.c is marked as standard while > all(?) uses of racct API are placed under RACCT option. Not all. I think some code was not easy to put under RACCT. > Ditto for kern_rctl.c/RCTL. > I think that excluding these file if the options are not used would help to catch > cases where the API is used unconditionally and it would also help to reduce > kernel sizes a tiny bit too. > -- Andrey Zonov [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org iQEcBAEBAgAGBQJQRj7uAAoJEBWLemxX/CvT7xUH/iL45f2olmOFCbV4dhxukTx0 +x7e6fRlJHxzb9rfglsfcOMdHLHd+8z2Qewq7VaJvyHvu5WouLNynE6TSs9oa4ru a+kdawS9bXc7pG3RHuXb+V638Xs4MiKtxwgbD2pI+2kRVrVyLutLCJ9bve09ihLA VVwCDpIwK7GgyfDGsHJisYxcb7QCChKz+UGkHZKLmma5PLt+DfTzpkAs1rR+vZ43 jjMSb5FsYa5qfbJQslU3dRMzRiU/PqEyBrPcOSjUHgvEGN9Kr5o1xRn73NFqKO1y avYj2gCTYSWLC2CFkqpoxEn18Rjx/s8azzz9g+TY69iBCd2DWpCZCYKczNl5NEk= =jDvD -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50463EEB.60207>