Date: Mon, 22 Oct 2012 17:18:11 -0600 From: Peter Grehan <grehan@freebsd.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r241744 - projects/bhyve/usr.sbin/bhyve Message-ID: <5085D433.4020101@freebsd.org> In-Reply-To: <20121021121006.GA96141@stack.nl> References: <201210191811.q9JIBIQu049356@svn.freebsd.org> <20121021121006.GA96141@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
> Case 4 looks wrong. A 32-bit write clears the top 32 bits of the > register instead of preserving them. Yep, you're right. How about: > + case 4: > + val = (reg & ~0xffffffffUL) | (operand & 0xffffffffUL); > + break; > I have no idea whether this will actually fix/break anything. Lucky so far but it would be sure to blow up in the future. later, Peter.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5085D433.4020101>