Date: Tue, 23 Oct 2012 10:44:38 -0600 From: Peter Grehan <grehan@freebsd.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r241744 - projects/bhyve/usr.sbin/bhyve Message-ID: <5086C976.9060705@freebsd.org> In-Reply-To: <20121023095549.GA27951@stack.nl> References: <201210191811.q9JIBIQu049356@svn.freebsd.org> <20121021121006.GA96141@stack.nl> <5085D433.4020101@freebsd.org> <20121023095549.GA27951@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/23/12 3:55 AM, Jilles Tjoelker wrote: > On Mon, Oct 22, 2012 at 05:18:11PM -0600, Peter Grehan wrote: >>> Case 4 looks wrong. A 32-bit write clears the top 32 bits of the >>> register instead of preserving them. > >> Yep, you're right. How about: > >> > + case 4: >> > + val = (reg & ~0xffffffffUL) | (operand & 0xffffffffUL); >> > + break; > > I think you mean: > val = operand & 0xffffffffUL; > > Right? Don't think so - the high 32 bits of the target register need to be or'd in, as you originally mentioned. later, Peter.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5086C976.9060705>