Date: Fri, 24 May 2019 09:24:30 -0500 From: Jason Bacon <bacon4000@gmail.com> To: Mark Millard <marklmi@yahoo.com> Cc: Francis Little <oggy@farscape.co.uk>, freebsd-ppc@freebsd.org Subject: Re: Mac G5 X11 performance Message-ID: <508eedcf-fb79-ac2c-1495-a9b39bb55100@gmail.com> In-Reply-To: <B1480160-A88E-4181-A468-B03D2809D0ED@yahoo.com> References: <d2621743-183e-d40b-71fe-6f14b30cd014@gmail.com> <CAGSRtz40CiM0L1gZgqUD1Yc6WWVTNyasMEc4xL1CvV1NjTj7mA@mail.gmail.com> <e95a4021-ee14-7cf6-2ef8-0af7d6a4156a@gmail.com> <B1480160-A88E-4181-A468-B03D2809D0ED@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Nice work. I confirmed that this patch fixes the build on a stock gcc
4.2 based installation.
Is anyone on this list able to commit it?
On 2019-05-23 19:58, Mark Millard wrote:
> I'm able to build devel/qt5-core based on:
>
> # svnlite diff/usr/ports/Mk/Uses/
> Index: /usr/ports/Mk/Uses/qt-dist.mk
> ===================================================================
> --- /usr/ports/Mk/Uses/qt-dist.mk (revision 501994)
> +++ /usr/ports/Mk/Uses/qt-dist.mk (working copy)
> @@ -251,7 +251,7 @@
> .if ${_QT_VER:M5}
> post-patch: gcc-post-patch
> gcc-post-patch:
> - ${REINPLACE_CMD} 's|%%LOCALBASE%%|${LOCALBASE}|' \
> + ${REINPLACE_CMD} 's|%%LOCALBASE%%|${LOCALBASE}|g' \
> ${WRKSRC}/mkspecs/common/gcc-base.conf \
> ${WRKSRC}/mkspecs/freebsd-g++/qmake.conf
> ${REINPLACE_CMD} 's|%%GCC_DEFAULT%%|${GCC_DEFAULT}|g' \
>
> I noticed that my build logs had %%LOCALBASE%% text that had
> not been replaced, in particular the 2nd one on a particular
> line. That lead to noticing the missing "g".
>
> (I'm not a ports committer or maintainer.)
>
> I experiment with a system-clang-8 and base/binutils based
> powerpc64 environment, instead of gcc 4.2.1 based. So direct
> inference of others being able to do the same would not
> apply. But it seems likely to me.
>
>
> Side note:
>
> qt-dist.mk sometimes uses -e with ${REINPLACE_CMD} even when
> only one command is being fed to sed, a context in which the -e
> is optional.
--
Earth is a beta site.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?508eedcf-fb79-ac2c-1495-a9b39bb55100>