Date: Wed, 31 Oct 2012 12:41:29 -0500 From: Joseph a Nagy Jr <jnagyjr1978@gmail.com> To: gahr@FreeBSD.org Cc: ports@freebsd.org, Chris Rees <utisoft@gmail.com> Subject: Re: tk85 Port Maintenance Message-ID: <509162C9.9060701@gmail.com> In-Reply-To: <20121031165507.GF90275@gahrfit.gahr.ch> References: <509121B3.3040307@gmail.com> <20121031135749.GC90275@gahrfit.gahr.ch> <50913253.3060700@gmail.com> <20121031152109.GD90275@gahrfit.gahr.ch> <CADLo83_VSLt5t31bJbu3-UCuGkNuNnnBEbMXWVd2fhvVwryP5g@mail.gmail.com> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig4D9A4F2BA43CAF606B552EB4
Content-Type: multipart/mixed;
boundary="------------080600030401020608050702"
This is a multi-part message in MIME format.
--------------080600030401020608050702
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On 10/31/12 11:55, Pietro Cerutti wrote:
> On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote:
<snip>
>> New diff[0], undoing some of the earlier changes even though portlint
>> complains:
>>
>> portlint ~/port-maintenance/tk85/
>> WARN: Makefile: unless this is a master port, COMMENT has to be set by=
>> "=3D", not by "?=3D".
>=20
> This *is* a master port, so it's ok to have COMMENT?=3D
>=20
>> WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
>=20
> This should be fixed as portlint suggests.
>=20
>> WARN: Makefile: no port directory
>> /usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is
>> listed in LIB_DEPENDS.
>=20
> I would try and use USE_TCL instead of LIB_DEPENDS here
>=20
>> WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in=
>> Xft.2 unless it is really necessary.
>=20
> This should be fixed as portlint suggests.
>=20
>> 0 fatal errors and 4 warnings found.
>>
>> [0]: http://pastebin.com/apf1Y9H0
>=20
> I'll have a look at it on Friday, thanks!
>=20
>=20
Going ahead to make those changes, old pastebin link is defunct.
New diff with all changes:
http://pastebin.com/iwhpXfcp
--=20
Yours in Christ,
Joseph A Nagy Jr
"Whoever loves instruction loves knowledge, But he who hates correction
is stupid." -- Proverbs 12:1
Emails are not formal business letters, whatever businesses may want.
Original content CopyFree (F) under the OWL http://owl.apotheon.org
--------------080600030401020608050702--
--------------enig4D9A4F2BA43CAF606B552EB4
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQEcBAEBAgAGBQJQkWLKAAoJECqR4kIlFcuBN6UIAKMAneFnWTXgdLZpXB+X2Kbm
k/bwdHTCdW+53T4zjtKlNYye9dDQjO3QaVSLU39jfE+q9AKh7mFlzUj3eEOgov2/
fuMWpQoD6fs+rbwPxOQDGzarl2S+xz3x1vzhXtl13pXQfg2aZO1rkYNhw6y5RRgn
126E+CIZ1eHSySsQj3+wqL0EzZmBeQqqI6M3CqTlBSVWEAKQAthglNhnbY6VJ6L+
cLcR/QkducftIbkOX/eSJMZ+XqXWCw5MbfE9QIkwnEYTpseSinsUN034SxGm6+Ny
Ye7o5DOU6njU0ocCcgVKgsLiUVGZsCKj0X6cFfQcTkiAX/lxHXEbSOBbqkAxe2E=
=iQ39
-----END PGP SIGNATURE-----
--------------enig4D9A4F2BA43CAF606B552EB4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?509162C9.9060701>