Date: Mon, 14 Jan 2013 08:28:41 -0500 From: Fbsd8 <fbsd8@a1poweruser.com> To: Lowell Gilbert <freebsd-questions-local@be-well.ilk.org> Cc: Adam Vande More <amvandemore@gmail.com>, FreeBSD questions <questions@freebsd.org> Subject: Re: sh script problem with capturing return code Message-ID: <50F40809.3020005@a1poweruser.com> In-Reply-To: <44libw8tiz.fsf@lowell-desk.lan> References: <50EC9009.3030305@a1poweruser.com> <20130108224626.8c2d89cd.freebsd@edvax.de> <50EC99F2.3020404@a1poweruser.com> <44d2xevlhb.fsf@lowell-desk.lan> <50ED88CF.7060308@a1poweruser.com> <448v82unxb.fsf@lowell-desk.lan> <444niqum7n.fsf@lowell-desk.lan> <44zk0it6t5.fsf@lowell-desk.lan> <44r4ltu8zp.fsf@lowell-desk.lan> <CA%2BtpaK3xUAz_F%2Bd02Qckkgb%2Bm1bFdBVTMJ7tFp3RJ4z5e6988A@mail.gmail.com> <44libw8tiz.fsf@lowell-desk.lan>
index | next in thread | previous in thread | raw e-mail
Lowell Gilbert wrote: > Adam Vande More <amvandemore@gmail.com> writes: > >> On Wed, Jan 9, 2013 at 7:23 PM, Lowell Gilbert < >> freebsd-questions-local@be-well.ilk.org> wrote: >> >>> Lowell Gilbert <freebsd-questions-local@be-well.ilk.org> writes: >>> >>>> I think it's a real bug, and the test cases don't cover "extra" elements >>>> at all. Now I just have to figure out the right fix. >>> I'm pretty sure that the fix is just to set rval on jumping to the >>> "extra" tag in vwalk() in src/usr.sbin/mtree/verify.c. >>> >>> But my hot water heater just exploded, so I may not look at code for a >>> few more days. >> >> I think they are importing NetBSD's updated mtree, perhaps already fixed >> there. > > It isn't. Which means I probably should submit fixes to multiple places. > > Although NetBSD's changes seem fairly minor to me, from a quick look. > The merge should not be difficult, no matter how it's approached. > > Let me be sure I understand you correctly. Your saying you tested the NetBSD version of mtree that was committed into 10.0 head and it also has the bug we found?home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50F40809.3020005>