Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 31 Mar 2013 18:25:37 -0400
From:      "Adrian Chadd" <adrian.chadd@gmail.com>
To:        "Raphael Kubo da Costa" <rakuco@freebsd.org>, "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org>
Subject:   Re: [rft] ar9300 HAL updated
Message-ID:  <5158b7e0.897aec0a.42d0.ffffaac9@mx.google.com>
In-Reply-To: <86bo9z39q0.fsf@orwell.Elisa>

next in thread | previous in thread | raw e-mail | index | archive | help
Look in ath/makefile .. At the bottom. There's clang warning overrides ther=
e. Uncomment them!


Adrian



Sent from my Palm Pre on AT&amp;T
On Mar 31, 2013 11:54 AM, Raphael Kubo da Costa &lt;rakuco@freebsd.org&gt;=
 wrote:=20

Adrian Chadd &lt;adrian@freebsd.org&gt; writes:



&gt; I've just updated the AR9300 HAL to the March 13 snapshot from QCA.

&gt;

&gt; This includes calibration and TX power calibration changes that may

&gt; improve stability.

&gt;

&gt; As always, it's possible I broke something!

&gt;

&gt; I'd appreciate it if people would test this in STA and AP mode.



I'm at r248944 here using HEAD.



After checking out the code, I created the expected symlinks at the new

contrib/ location (BTW, are you sure you want

sys/contrib/sys/dev/ath instead of sys/contrib/dev/ath, which seems to

be the chosen location for other modules?).



The first error I got was in ar9300_radio.c:90 -- clang complained

`ichan' was not being used.



It is now failing like this:



cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc=
  -I. -I/usr/src/sys/modules/ath/../..

/dev/ath -I/usr/src/sys/modules/ath/../../dev/ath/ath_hal -I. -I/usr/src/sy=
s/modules/ath/../../contrib/sys/dev/a

th/ath_hal/ -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/ORWE=
LL/opt_global.h -I. -I@ -I@/contrib/a

ltq -fno-common -g -fno-omit-frame-pointer -I/usr/obj/usr/src/sys/ORWELL =
 -mno-aes -mno-avx -mcmodel=3Dkernel -mno

-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables=
 -ffreestanding -fstack-protector -std=3D

iso9899:1999 -Qunused-arguments -fstack-protector -Wall -Wredundant-decls=
 -Wnested-externs -Wstrict-prototypes

-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-poi=
nter-sign -fformat-extensions  -Wmiss

ing-include-dirs -fdiagnostics-show-option  -Wno-error-tautological-compare=
 -Wno-error-empty-body  -Wno-error-pa

rentheses-equality  -c /usr/src/sys/modules/ath/../../contrib/sys/dev/ath/a=
th_hal/ar9300/ar9300_eeprom.c

In file included from /usr/src/sys/modules/ath/../../contrib/sys/dev/ath/at=
h_hal/ar9300/ar9300_eeprom.c:27:

/usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300tem=
plate_generic.h:113:3: error:

      implicit conversion from 'int' to 'u_int8_t' (aka 'unsigned char') ch=
anges value from -477 to 35

      [-Werror,-Wconstant-conversion]

                FREQ2FBIN(2412, 1),

                ^~~~~~~~~~~~~~~~~~

/usr/src/sys/modules/ath/../../contrib/sys/dev/ath/ath_hal/ar9300/ar9300eep=
=2Eh:142:65: note: expanded from macro

      'FREQ2FBIN'

    (((y) =3D=3D HAL_FREQ_BAND_2GHZ) ? ((x) - 2300) : (((x) - 4800) / 5))

                                                   ~~~~~~~~~~~~~^~~

The error message is repeated multiple times (one for each FREQ2FBIN call).



_______________________________________________

freebsd-wireless@freebsd.org mailing list

http://lists.freebsd.org/mailman/listinfo/freebsd-wireless

To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org"





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5158b7e0.897aec0a.42d0.ffffaac9>