Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Sep 2013 15:59:10 +0200
From:      Andreas Longwitz <longwitz@incore.de>
To:        Andriy Gapon <avg@FreeBSD.org>
Cc:        freebsd-fs@FreeBSD.org
Subject:   Re: zfs panic during find(1) on zfs snapshot directory
Message-ID:  <522F25AE.1080309@incore.de>
In-Reply-To: <522E0118.5020106@FreeBSD.org>
References:  <522DF5A9.4070103@incore.de> <522E0118.5020106@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Thanks for quick answer !

> My personal recommendation is to keep .zfs directory hidden and/or perform only
> basic operations on entries under it while ensuring that there is only one
> process at a time that peeks there.
> 
> The gfs stuff that handles .zfs operations is really very broken on FreeBSD[*].
> If you are interested, I have a patch that should some of the mess, but not all.
> 
> [*] To see what I mean run several of the following shell loops in parallel:
> while true; do ls -l /pool/fs/.zfs/ >/dev/null; done

Ok, I was not aware of the problematic caused by visible snapdir
property. I think your recommendation to use the default snapdir
property hidden is fine for me and the panic I have described will not
happen again.

On the other side a panic should not happen when a user configures
something else than the default. Therefore I am interested in helping to
test the broken gfs stuff on some of my test servers, so your offered
patch is welcome.

I run zfs on production for a half year now, and I like to note that
this panic was the first problem on all of my (eight) production servers
running zfs. The only open zfs problem I have is described in kern/180060.

-- 
Andreas Longwitz




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?522F25AE.1080309>