Date: Mon, 18 Nov 2013 11:36:25 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Steven Hartland <killing@multiplay.co.uk>, freebsd-stable@FreeBSD.org Subject: Re: Help with filing a [maybe] ZFS/mmap bug. Message-ID: <5289DF99.9080101@FreeBSD.org> In-Reply-To: <705640231AF04A91B66B0654D2531EC9@multiplay.co.uk> References: <20967.760.95825.310085@gargle.gargle.HOWL><51E80B30.1090004@FreeBSD.org><20968.10645.880772.30501@gargle.gargle.HOWL><520202E5.30300@FreeBSD.org><20994.55913.93606.436124@gargle.gargle.HOWL><FEE7BDCF7F494EE1BA0BE9424275AA91@multiplay.co.uk> <21111.12085.958991.356982@gargle.gargle.HOWL> <4EB902F80CE84DD2BF36C85EF4CE8EF8@multiplay.co.uk> <5284B8A5.8040604@FreeBSD.org> <52889105.7040404@FreeBSD.org> <9A58D6B0691A4C1294883AD91F9D4743@multiplay.co.uk> <5289D2FB.1010600@FreeBSD.org> <705640231AF04A91B66B0654D2531EC9@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
on 18/11/2013 11:23 Steven Hartland said the following: > ----- Original Message ----- From: "Andriy Gapon" <avg@FreeBSD.org> > To: "Steven Hartland" <killing@multiplay.co.uk>; <hartzell@alerce.com>; > <freebsd-stable@FreeBSD.org> > Sent: Monday, November 18, 2013 8:42 AM > Subject: Re: Help with filing a [maybe] ZFS/mmap bug. > > >> on 17/11/2013 17:53 Steven Hartland said the following: >>> >>> ----- Original Message ----- From: "Andriy Gapon" <avg@FreeBSD.org> >>>> - vm_page_clear_dirty(pp, off, nbytes); >>>> + if (nbytes != 0) >>>> + vm_page_clear_dirty(pp, off, nbytes); >>>> } >>>> break; >>> >>> Thanks Andriy, looking to test this here but 8.3 doesn't have a page_busy >>> method in zfs_vnops.c so I'm not sure how to proceed on this? >> >> Does it have vm_page_clear_dirty call? > > Nope. > Then you do not have this bug. It's possible that you might have a different bug, though. Perhaps merge the relevant change from stable/8 and then apply the patch?.. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5289DF99.9080101>