Date: Sun, 23 Mar 2014 11:20:50 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r348866 - head/ports-mgmt/poudriere-devel Message-ID: <532F09E2.6090309@FreeBSD.org> In-Reply-To: <79C5E9B2B1255838D240E362@atuin.in.mat.cc> References: <201403231540.s2NFeBjV061182@svn.freebsd.org> <9753239EA269BEFE3D11835F@atuin.in.mat.cc> <532F08B7.8010602@FreeBSD.org> <79C5E9B2B1255838D240E362@atuin.in.mat.cc>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On 3/23/2014 11:18 AM, Mathieu Arnold wrote:
>
>
> +--On 23 mars 2014 11:15:51 -0500 Bryan Drewery <bdrewery@FreeBSD.org>
> wrote:
> | On 3/23/2014 11:11 AM, Mathieu Arnold wrote:
> |> +--On 23 mars 2014 15:40:11 +0000 Bryan Drewery <bdrewery@FreeBSD.org>
> |> wrote:
> |> | .include <bsd.port.options.mk>
> |> |
> |> | +post-install:
> |> | .if ${PORT_OPTIONS:MZSH}
> |> | -PLIST_FILES+= share/zsh/site-functions/_poudriere
> |> | -PLIST_DIRSTRY+= share/zsh/site-functions
> |> | -PLIST_DIRSTRY+= share/zsh/
> |> | -.else
> |> | -MAKE_ENV+= NO_ZSH=yes
> |> | + @${MKDIR} ${STAGEDIR}${PREFIX}/share/zsh/site-functions/
> |> | + ${INSTALL_DATA} ${WRKSRC}/completions/zsh/_poudriere \
> |> | + ${STAGEDIR}${PREFIX}/share/zsh/site-functions/
> |> | .endif
> |>
> |> I think you could do without the include and always install the file.
> |>
> |
> | What?
>
> Replace:
>
> .include <bsd.port.options.mk>
>
> post-install:
> .if ${PORT_OPTIONS:MZSH}
> @${MKDIR} ${STAGEDIR}${PREFIX}/share/zsh/site-functions/
> ${INSTALL_DATA} ${WRKSRC}/completions/zsh/_poudriere \
> ${STAGEDIR}${PREFIX}/share/zsh/site-functions/
> .endif
>
> With:
>
> post-install:
> @${MKDIR} ${STAGEDIR}${PREFIX}/share/zsh/site-functions/
> ${INSTALL_DATA} ${WRKSRC}/completions/zsh/_poudriere \
> ${STAGEDIR}${PREFIX}/share/zsh/site-functions/
>
> The package won't register the file if the option is disabled, and it
> removes the need for make to parse bsd.port.mk twice.
>
And then there is a stage orphan.
No.
--
Regards,
Bryan Drewery
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTLwniAAoJEDXXcbtuRpfPrhIIALJjUFT8W8hngNyCLMILB5aB
DJq/8ufZoHewxjBXHvA9i3RHZDJQTBxPmlil+8kjQgM9B25x1hnoOFzGNIzW7a+P
x8iwAZVKdKh5wirDuAgB2EqN81pCZxzi06Ag3tkVhTnxozPrnd0mMph3xoHjoicH
e8gA2xw12/M20hJZFt+uomoySMwFhFcXXj26G1slep01rRmE6ONJaZrCtw7JSD7/
fIUCFRPBOUyFi87/2JwrgJHsMtVnRrCXin5VhKeQSkGv1aLA7yjaHbTUH8spJozh
pDlhpIS0t66Bjc/jJxKQBLZpxn0pdiSfELdJG+doTi8hL06RJd3U0aLM7vW0h30=
=skMu
-----END PGP SIGNATURE-----
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?532F09E2.6090309>