Date: Wed, 21 May 2014 23:51:13 -0400 From: Allan Jude <allanjude@freebsd.org> To: Benedict Reuschling <bcr@freebsd.org>, Warren Block <wblock@wonkity.com>, Eitan Adler <eadler@freebsd.org>, freebsd-fs@freebsd.org Subject: [patch] zfs sysctl patch Message-ID: <537D7431.4070103@freebsd.org>
next in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--UmPQgGsCjoFNi1qQdlPmNlfrflLMA4U1l
Content-Type: multipart/mixed;
boundary="------------030809030105050304080906"
This is a multi-part message in MIME format.
--------------030809030105050304080906
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
A recent commit (r266497 by smh) added a number of new sysctls for ZFS
Two of these had minor typos, and the phrasing of another was very awkwar=
d.
---------------
Improve sysctl descriptions for:
vfs.zfs.dirty_data_max
vfs.zfs.dirty_data_max_max
vfs.zfs.dirty_data_sync
--=20
Allan Jude
--------------030809030105050304080906
Content-Type: text/plain; charset=windows-1252;
name="src.zfs.sysctl_desc.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="src.zfs.sysctl_desc.diff"
Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c (revision 2=
66517)
+++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c (working co=
py)
@@ -144,13 +144,13 @@
TUNABLE_QUAD("vfs.zfs.dirty_data_max", &zfs_dirty_data_max);
SYSCTL_UQUAD(_vfs_zfs, OID_AUTO, dirty_data_max, CTLFLAG_RWTUN,
&zfs_dirty_data_max, 0,
- "The dirty space limit in bytes after which new writes are halted un=
til "
- "space becomes available");
+ "The maximum amount of dirty data in bytes after which new writes ar=
e "
+ "halted until space becomes available");
=20
TUNABLE_QUAD("vfs.zfs.dirty_data_max_max", &zfs_dirty_data_max_max);
SYSCTL_UQUAD(_vfs_zfs, OID_AUTO, dirty_data_max_max, CTLFLAG_RDTUN,
&zfs_dirty_data_max_max, 0,
- "The absolute cap on diry_data_max when auto calculating");
+ "The absolute cap on dirty_data_max when auto calculating");
=20
TUNABLE_INT("vfs.zfs.dirty_data_max_percent", &zfs_dirty_data_max_percen=
t);
SYSCTL_INT(_vfs_zfs, OID_AUTO, dirty_data_max_percent, CTLFLAG_RDTUN,
@@ -160,7 +160,7 @@
TUNABLE_QUAD("vfs.zfs.dirty_data_sync", &zfs_dirty_data_sync);
SYSCTL_UQUAD(_vfs_zfs, OID_AUTO, dirty_data_sync, CTLFLAG_RWTUN,
&zfs_dirty_data_sync, 0,
- "Force at txg if the number of dirty buffer bytes exceed this value"=
);
+ "Force a txg if the number of dirty buffer bytes exceed this value")=
;
=20
static int sysctl_zfs_delay_min_dirty_percent(SYSCTL_HANDLER_ARGS);
/* No zfs_delay_min_dirty_percent tunable due to limit requirements */
--------------030809030105050304080906--
--UmPQgGsCjoFNi1qQdlPmNlfrflLMA4U1l
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJTfXQzAAoJEJrBFpNRJZKfsGgP/Rua9QTnEf3UgRJEtpndNbwW
OWxPKJvSScn4CFqxLO65KMZnA1HiRVV5qdgxztF7fdc4yiJv6E5PFwk899etKcy+
DWM9BcB56ssAJZ6gA6Tfm0oI7mrT5OC3RacJJBGAkUlMt4GzzNqwsZH4fV9FR/X8
GJFek6NHJcAIFYI5flRd6DXIK+pkDka8e4CrW55kTJZ/W+IYD3KlFjLFILSV2cqB
3dn0UtQUkKjDpKEYM3GenmT5/8DlXflu6H+27UYaTeJTz0WZs0Awr2We6mFI2Fxy
PuhPagLois7mmLVxbl+TuwGW6uIfFF78OpiNHQXDn2m5GJI9WSM8OQhj98yrisnH
xTwvCLv2fp7CheFRGzOZfUFhog03JDrNqWYsbSlBZ/I3XHRqNNNPuEJFU4l575H7
mBqBpRt+hRe4dnU6WPOQlVfiOiOSLmldd8RuiVomXhByOlnwxqLIcouhy6g/g+OK
umD3sGMLMicfOFbJcizZsjxS9+UxXJNiZYa9fT2lnguzSBfu2szfJQn5/HPnzF1G
5pKTYNWgr4bi6P7RuLqBLuS2eHKaood1h3k7PeSo/uJF4oBfS02K3RjUaXzRG1LW
z2qNC3aXNzj1J6K3KshVvGAkfmWXsgqEmBnC3lU5NI0tABav0D3eAq9MmNpnqdlV
kRk6f/Na1CgCE9ZdM2lp
=MQAS
-----END PGP SIGNATURE-----
--UmPQgGsCjoFNi1qQdlPmNlfrflLMA4U1l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?537D7431.4070103>