Date: Tue, 10 Jun 2014 20:47:58 +0200 From: olli hauer <ohauer@gmx.de> To: Kurt Jaeger <pi@FreeBSD.org> Cc: Frederic Culot <culot@FreeBSD.org>, apache@freebsd.org, skv@FreeBSD.org Subject: Re: www/p5-libapreq2: libtool fix, strip libs, pkg-plist followup, p5-fix Message-ID: <539752DE.5060208@gmx.de> In-Reply-To: <20140610094949.GY3484@f10.opsec.eu> References: <20140608081334.GK1427@f10.opsec.eu> <20140608083407.GL1427@f10.opsec.eu> <20140608083636.GM1427@f10.opsec.eu> <20140608085842.GO1427@f10.opsec.eu> <53945E98.3080408@gmx.de> <20140610094949.GY3484@f10.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-06-10 11:49, Kurt Jaeger wrote:
> Hi!
>
> Back to my proposed change for www/libapreq2 and this question:
>
>>> Would it be more useful to make the slave port (p5-libapreq2)
>>> a seperate port depending on the other ?
>
> Looking at the pkg-plist and Makefile mess: Is it really useful
> to have this master/slave port or should I split and depend on libapreq2 ?
>
I suspect this port will never win a pretty contest ...
running a short grep over the tree shows there are only two libapreq2 consumers
- www/mod_amazon_proxy
- www/p5-libapreq2
but eleven p5-libapreq consumers
- net-mgmt/netdisco
- net-mgmt/netdot
- www/foswiki-ModPerlEngineContrib
- www/p5-Apache-Gallery
- www/p5-Apache2-SiteControl
- www/p5-CGI-Application-Plugin-Apache
- www/p5-HTML-Mason
- www/p5-Maypole
- www/rt38
- www/rt40.cpan
- www/rt42.cpan
The line WITH_MODPERL2 is from history where apache13 / mod_perl was also in the tree (WITH_MODPERL) (w.o 2)
Since WITH_MODPERL2 is only defined in libapreq2, p5-libapreq2 it can be replaced without any side effects to reflect p5-libapreq2.
Splitting the port is maybe easier with two pkg-plists.
One part slipped over my last mail and should be fixed in the final commit
post-stage:
-+ ${STRIP_CMD}·${STAGEDIR}/usr/local/lib/libapreq2.so.3.8.0
-+ ${STRIP_CMD}·${STAGEDIR}/usr/local/libexec/apache22/mod_apreq2.so
++ ${STRIP_CMD}·${STAGEDIR}${PREFIX}//lib/libapreq2.so.3.8.0
++ ${STRIP_CMD}·${STAGEDIR}${PREFIX}/${APACHEMODDIR}/mod_apreq2.so
--
Regards,
olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?539752DE.5060208>